FEAT migrate to TargetConfiguration from TargetCapabilities#1588
Draft
hannahwestra25 wants to merge 4 commits intomicrosoft:mainfrom
Draft
FEAT migrate to TargetConfiguration from TargetCapabilities#1588hannahwestra25 wants to merge 4 commits intomicrosoft:mainfrom
hannahwestra25 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
romanlutz
approved these changes
Apr 10, 2026
Comment on lines
38
to
+39
| from pyrit.prompt_target.common.target_capabilities import TargetCapabilities | ||
| from pyrit.prompt_target.common.target_configuration import TargetConfiguration |
Contributor
There was a problem hiding this comment.
Can we have imports directly from pyrit.prompt_target? Doing deep imports limits our ability to change the internal structure later on. If it's not exported at that levelwe should probably fix that. This applies in all files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the standalone TargetCapabilities object with a higher-level TargetConfiguration in targets. Note that TargetCapabilities is still supported and a deprecation warning is displayed
see #1573 for details about TargetConfiguration
Tests and Documentation
updated tests & notebooks