Implemented -[NSConditionLock lockWhenCondition:beforeDate:] #2508
Conversation
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Thanks, @triplef!
I'd like to see a few comments on the time manipulation, and perhaps some diversity in naming between t and tv (since they're close enough but totally different types.)
I wouldn't hold up the approval for that, though!
Note to merger: reword in imperative <=72 before merge
DHowett-MSFT
left a comment
DHowett-MSFT
left a comment
There was a problem hiding this comment.
I've thought about this a bit more, and it would be great if you'd add some unit tests to the existing NSConditionLock tests for this!
| - (BOOL)lockWhenCondition:(NSInteger)condition beforeDate:(NSDate*)date { | ||
| UNIMPLEMENTED(); | ||
| return NO; | ||
| int rc; |
There was a problem hiding this comment.
I assume rc is for "return code"? Please don't choose single letter / abbreviated variable names as it is unclear to future readers what the abbreviation / implicit word is. Perhaps statusCode / returnCode, etc here?
There was a problem hiding this comment.
@DHowett-MSFT I didn't see the surrounding context sorry. Probably ok then.
|
@bbowman The rest of this file uses |
5 participants
Fixes #845.
This change is