docs(skill): point the finish-release opencode gate at a check that exists - #149
Merged
David Koleczek (DavidKoleczek) merged 1 commit intoAug 25, 2026
Conversation
…xists Phase 4 told the runner to execute tests/test_version.py and tests/test_prereqs.py in amplifier-app-opencode. Those files were removed in that repo's PR #21, which retired its whole unit-test layer in favour of spec-as-contract e2e coverage, so the command errors with "file or directory not found" and no verification happens. Point it at `make check` instead, and add a read-back of the three constants. Lint accepts any string, so the read-back is what actually catches a wrong or typo'd floor before it reaches a user's install. The e2e suites are not invoked here: they need a DTU, they cost minutes, and the onboarding suite pins its fake agent to 99.0.0 specifically so it does not track the floor. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of
amplifier-agent-finish-release-processinstructed the runner toverify the
amplifier-app-opencodefloor bump with:Neither file exists. Both were removed in that repo's PR #21, which retired its
entire unit-test layer in favour of spec-as-contract e2e coverage:
So the command errors with
file or directory not found, no tests run, and thephase that is supposed to catch a wrong floor verifies nothing. This surfaced
while cutting 0.15.1, where the step could not be performed as written.
Change
Point the step at
make check, which is that repo's real fast gate (ruff lintand format), and follow it with a read-back of the three constants.
The read-back is not decoration.
make checkaccepts any string, so a typo'dor stale
MIN_AGENT_VERSIONpasses lint cleanly and then fails on a user'smachine at install time — that constant drives a forced reinstall and names the
exact git tag the launch-time self-heal installs. Reading the values back and
comparing them to the tag just pushed is the only thing in the phase that
actually checks the number.
What this deliberately does not do
restructuring in that repo, not an accident to undo from here.
not belong in this step. They would not help regardless: the onboarding suite
pins its fake agent to
99.0.0specifically so it does not track the floor,and the only two references to these constants under
tests/are a commentand a docstring, not assertions.
The replacement commands were run against
amplifier-app-opencoderather thanassumed correct.
🤖 Generated with Amplifier