chore(deps): raise amplifier-agent floor to 0.14.0 - #23
Merged
Conversation
amplifier-opencode drives `serve` for every turn, and 0.14.0 is the first engine version whose serve lifecycle is correct on Windows. Most consequentially, `os.kill(pid, 0)` was used as a benign liveness probe; on Windows CPython maps CTRL_C_EVENT to GenerateConsoleCtrlEvent and CTRL_C_EVENT == 0, so signal 0 delivered a real console Ctrl+C to the target's process group -- `serve status` could interrupt the server it was reporting on. 0.14.0 also stops refusing to write serve.json on Windows, where the 0600/0700 permission verification could never pass against NTFS, and reads Windows-authored agent .md and credentials.json as UTF-8 with an optional BOM. AGENT_PINNED_REF follows to v0.14.0, which is tagged and released upstream. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises
MIN_AGENT_VERSIONfrom 0.12.0 to 0.14.0, following the upstreamamplifier-agent0.14.0 release (microsoft/amplifier-agent#137, taggedv0.14.0).Why this release forces the floor
The floor is a requirement statement, not a mirror of the latest engine release, so it moves only when this tool depends on something the new engine introduced. It does here.
We drive
servefor every turn, and 0.14.0 is the first engine version whose serve lifecycle is correct on Windows. Three POSIX assumptions were wrong below it. The damaging one:os.kill(pid, 0)was used as a benign liveness probe, but on Windows CPython mapsCTRL_C_EVENTtoGenerateConsoleCtrlEvent, and becauseCTRL_C_EVENT == 0, signal 0 delivers a real console Ctrl+C to the target's process group —serve statuscould interrupt the very server it was reporting on. Alongside that,signal.SIGKILLdoes not exist on Windows and raisedAttributeErrorwhen escalating a stop, andstart_new_session=Trueis a POSIX-only way to detach a restart.0.14.0 also stops refusing to write
serve.jsonon Windows, where the 0600/0700 permission verification could never pass against NTFS, and reads Windows-authored agent.mdandcredentials.jsonas UTF-8 with an optional BOM — previously a BOM-prefixed agent file silently spawned a sub-agent with the wrong tools, or none.Secondary, not load-bearing for the floor: the engine gained
geminiandvllmprovider modules, which surface throughGET /v1/modelsand so appear in the config we rewrite.Cost
AGENT_PINNED_REFfollows tov0.14.0, andAGENT_HARD_FLOORtracks the minimum, so every user below 0.14.0 is force-reinstalled at launch rather than left to self-update. That is the intended behavior for a floor bump, but it is a real cost worth naming: this is not a silent upgrade.v0.14.0is tagged and its GitHub Release is published, so the pinned ref resolves —install.shandamplifier-agent updateinstall from git and resolve through the Releases API.Verification
make checkis green (ruff check + format,src/andtests/).The two unit test files named by the release process,
tests/test_version.pyandtests/test_prereqs.py, do not exist in this repo — only a stale.pycfor the former remains. Nothing undertests/asserts on these constants; the only references intests/e2e/suites/onboarding/are comments, andFAKE_AGENT_VERSIONis pinned to99.0.0specifically so that suite does not track the floor. So there is no unit-level gate on this change, and the full e2e suite (which needs a DTU and Docker) has not been run against it here.Also updated the now-stale
(0.12.0 as of this writing)parenthetical in the onboarding conftest to match.