docs(experts): update core-expert + kernel-overview + §10 for v1.4.x lifecycle and pre-merge gate - #68
Merged
Conversation
…lifecycle and pre-merge gate Surface recent kernel changes (v1.4.0/v1.4.1) in the in-repo expert context so core-expert is current and CORE_DEVELOPMENT_PRINCIPLES §10 no longer contradicts release-mandate.md. agents/core-expert.md: - Rename RELEASE Mode "Post-Merge Gate" → "Pre-Merge Gate"; reframe trigger from "after a merge" to pre-merge; cite release-mandate.md as superseding §10 - New MODULE LIFECYCLE Mode covering mount() and on_session_ready() pairing, with no-timeout footgun, Python-only polyglot scope, failure isolation, dispatch ordering, fork semantics - Knowledge Base: add @core:CONTRACTS.md as authoritative cross-boundary reference (was missing); add @core:context/release-mandate.md as authoritative for the Pre-Merge Gate - Per-protocol contracts subdirectory clarified as deep-dive path, CONTRACTS.md as the canonical map context/kernel-overview.md: - "What the Kernel Provides" → new "Module Lifecycle" subsection naming mount() and on_session_ready() with one-line descriptions - "Module Protocols" → new "Module Lifecycle" subsection with signature blocks matching the existing protocol style; cites CONTRACTS.md as authoritative docs/CORE_DEVELOPMENT_PRINCIPLES.md §10: - Full rewrite to match the new pre-merge gate model - Title: "The Release Gate: Every Merge Gets a Release" → "The Release Gate: Merge Is Release" - Lists the five in-PR requirements (atomic version bump, Rust/Python symmetry, fresh wheel, E2E smoke test result, no [tool.uv.sources] overrides) - Documents who merges (core owner) and recovery via Incident Playbook - Cross-references release-mandate.md as canonical Verifies in-repo expert + dev docs against the policy codified by PR #64 (release-mandate pre-merge gate) and the lifecycle contract introduced by PR #63 (on_session_ready) and shipped via v1.4.1. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the in-repo expert context (
agents/core-expert.md,context/kernel-overview.md) to surface recent kernel changes (v1.4.0/v1.4.1), and rewritesdocs/CORE_DEVELOPMENT_PRINCIPLES.md §10so it no longer contradictscontext/release-mandate.md§ Pre-Merge Gate.This is a docs-only PR. No code changes. No version bump needed (no wheel-shipped code touched).
Why now
Two recent landings created a doc gap that PR #67's round-3 review surfaced:
core-expert.mdstill labeled its release mode "Post-Merge Gate" anddocs/CORE_DEVELOPMENT_PRINCIPLES.md §10still described the post-merge bump-then-tag flow. Direct readers of those files would follow the wrong process.Adversarial review by
systems-design:systems-design-critic(the "crusty old engineer" pass) confirmed both gaps as load-bearing and identified additional missed items (@core:CONTRACTS.mdnot referenced anywhere in core-expert.md, lifecycle signatures missing from the Module Protocols code-block listing) which are also addressed here.What changed
agents/core-expert.mdrelease-mandate.md § Pre-Merge Gateas authoritative and explicitly state it supersedes §10module:on_session_ready_failedevent, fork-per-session semantics@core:CONTRACTS.md(was missing entirely) as the canonical cross-boundary reference; added@core:context/release-mandate.mdas authoritative for the gate; clarifieddocs/contracts/subdirectory as protocol-specific deep dives, not the cross-boundary mapcontext/kernel-overview.mdmount()andon_session_ready()with concise descriptions and a pointer to CONTRACTS.mdmount()andon_session_ready()signature blocks alongside the existing five protocols (was inconsistent: protocols had signatures, lifecycle didn't)docs/CORE_DEVELOPMENT_PRINCIPLES.md §10(full rewrite)[tool.uv.sources]git overrides)release-mandate.mdas canonicalScope notes
bundle-awareness.md(foundation) — would have been context poisoning of a thin awareness pointer.Verification
git diff --stat main:No code changed; no tests required. The expert files are reference docs loaded on demand by their respective agents.