fix(deps): align wasmtime-wasi to v43 to match wasmtime - #80
Merged
Brian Krabach (bkrabach) merged 3 commits intoMay 18, 2026
Conversation
The wasmtime crate was bumped to v43 (via dependabot PR #74) but wasmtime-wasi remained pinned at v42, pulling two incompatible wasmtime versions into the dependency graph: error[E0308]: mismatched types --> crates/amplifier-core/src/bridges/wasm_tool.rs:66:43 | 66 | wasmtime_wasi::p2::add_to_linker_sync(&mut linker)?; | ---------------------------------- ^^^^^^^^^^^ expected | `&mut Linker<_>`, found `&mut Linker<WasmState>` | note: there are multiple different versions of crate `wasmtime` in the dependency graph This broke Rust Core CI on every PR (and silently on main, since the workflow only triggers on PRs targeting main). Fix: bump wasmtime-wasi to v43, aligning with the wasmtime crate. Both now resolve to 43.0.2. Verified locally with all four CI commands from .github/workflows/rust-core-ci.yml: - cargo check -p amplifier-core --features wasm ✓ - cargo check -p amplifier-core -p amplifier-core-py ✓ - cargo test -p amplifier-core --no-run ✓ - cargo fmt -p amplifier-core -p amplifier-core-py --check ✓ - cargo clippy -p amplifier-core -p amplifier-core-py -- -D warnings ✓ Co-authored-by: Amplifier <amplifier@microsoft.com>
Patch bump for the wasmtime-wasi alignment fix. Triggers PyPI wheel publication via Build Wheels workflow when v1.5.3 tag is pushed. Co-authored-by: Amplifier <amplifier@microsoft.com>
Missed this version stamp in the previous bump commit. The Python package's runtime __version__ must match pyproject.toml and the Cargo crate versions, or installed builds report stale version. Co-authored-by: Amplifier <amplifier@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Rust Core CI failure on every PR (and silently on main) caused by a wasmtime version mismatch.
Root cause
wasmtimewas bumped to v43 (via dependabot in #74) butwasmtime-wasiremained pinned at v42. The two crates pulled in incompatible versions ofwasmtimetransitively, sowasmtime_wasi::p2::add_to_linker_sync(&mut linker)failed to type-check because theLinker<T>types came from different wasmtime versions.Fix
One-line bump of
wasmtime-wasifrom"42"to"43"incrates/amplifier-core/Cargo.toml. Both crates now resolve to 43.0.2 cleanly.Verification
All four Rust Core CI commands run locally:
cargo check -p amplifier-core --features wasmcargo check -p amplifier-core -p amplifier-core-pycargo test -p amplifier-core --no-runcargo fmt -p amplifier-core -p amplifier-core-py --checkcargo clippy -p amplifier-core -p amplifier-core-py -- -D warningsNotes
.github/workflows/rust-core-ci.ymlison: pull_request: [main, rust-core]— does NOT run on push to main. That's why main went red silently. Worth a separate follow-up to addpush: [main]so future regressions are caught immediately.