ci: run Rust Core CI on push to main, not just PRs - #82
Merged
Conversation
The workflow was only triggered on pull_request and push to rust-core. This meant when main went red — as happened after IT's wasmtime auto-fix in #74 — there was no signal until the next PR opened. Add 'main' to the push branches so any direct push (merge, admin push, revert) triggers a full CI run on the new HEAD. Catches future regressions immediately. Co-authored-by: Amplifier <amplifier@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Rust Core CI workflow only triggers on pull requests and pushes to the
rust-corebranch. Pushes tomain(merge commits, admin pushes, reverts, dependabot auto-merges) do not run CI.This is how main went silently red after IT's wasmtime auto-fix in #74: the bump landed via dependabot auto-merge, no CI ran on the merge commit, and the breakage stayed hidden until the next PR (#79) opened and inherited the failed state.
Fix
One line — add
mainto the push branches:Effect
Future direct pushes to main run a full CI cycle on the new HEAD. Regressions are caught immediately, not at the next PR open.
Note
This is a small
.github/workflowschange — no Rust or Python code touched. CI on the PR will run via the existingpull_requesttrigger before this change lands. After merge, the next push to main will exercise the newpush: maintrigger.