chore(ci): bump GitHub Actions to Node 24-compatible versions - #83
Merged
Conversation
The workflow was only triggered on pull_request and push to rust-core. This meant when main went red — as happened after IT's wasmtime auto-fix in #74 — there was no signal until the next PR opened. Add 'main' to the push branches so any direct push (merge, admin push, revert) triggers a full CI run on the new HEAD. Catches future regressions immediately. Co-authored-by: Amplifier <amplifier@microsoft.com>
- actions/checkout: v4 → v6 (v6.0.2 latest; Node 24 since v5) - actions/setup-python: v5 → v6 (v6.2.0 latest; Node 24 dep upgrade) - actions/upload-artifact: v4 → v7 (v7.0.1 latest; Node 24 since v6) - actions/download-artifact v4 → v8 (v8.0.1 latest; Node 24 since v7) - PyO3/maturin-action: v1 unchanged (already runs on node24) No FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var needed — every action used in this workflow is already on Node 24 after this bump. Resolves GitHub's Node 20 deprecation deadline of 2026-06-02.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps all Node.js 20 GitHub Actions in the Build Wheels workflow to their latest Node 24-compatible versions, ahead of GitHub's enforcement deadline of 2026-06-02.
Version changes
actions/checkout@v4@v6actions/setup-python@v5@v6actions/upload-artifact@v4@v7actions/download-artifact@v4@v8PyO3/maturin-action@v1@v1PyO3/maturin-action— no change neededThe
v1tag already declaresruns: using: 'node24'in itsaction.yml(verified againsthttps://raw.githubusercontent.com/PyO3/maturin-action/v1/action.yml). No version bump or env-var workaround is required.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24— not addedAll actions in this workflow now use Node 24 natively; the env-var safety-net is not needed.
Breaking-change notes
actions/checkout@v6(v6.0.0): credentials are now persisted to a separate file rather than embedded in.git/config. No impact because no step reads credential config from git after checkout.actions/download-artifact@v8(v8.0.0): hash mismatches now error by default (previously a warning). This is a security improvement; wheel downloads in the same workflow run will have matching hashes.actions/download-artifact@v8(v5.0.0): path-output changed for single artifact downloads by artifact ID. Ourpublishjob usespattern: 'wheels-*'(by name), so this does not apply.ubuntu-latest,macos-latest,windows-latest) always satisfy this.Validation
yaml.safe_load