fix(spawn): case-insensitive model-glob matching for agent/session spawns - #265
Merged
Brian Krabach (bkrabach) merged 1 commit intoJul 5, 2026
Merged
Conversation
…awns spawn_utils model-hint resolution used raw fnmatch.filter (OS-dependent case); now lowercases both sides, consistent with the routing matrix, so spawned agent sub-sessions resolve mixed-case model ids correctly (e.g., `qwen3.6-*` -> `Qwen3.6-...`). Added tests proving routing hook config (custom_routing_dirs) deep-merges into spawned child sessions via compose()/merge_module_lists(), so the routing fix reaches agent sub-sessions. Test plan: uv run pytest tests/test_spawn_utils.py tests/test_bundle.py -q (all pass). Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Brian Krabach (bkrabach)
deleted the
fix/case-insensitive-model-glob-matching
branch
July 5, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technical Details
Bug: spawn_utils model resolution was OS-dependent
fnmatch.filter()for model-hint resolutionFix
fnmatch.filter([m.lower() for m in names], pattern.lower())Config propagation to spawned sessions
custom_routing_dirsconfig deep-merges into spawned child sessionsTesting
All pass, including new deep-merge verification tests.
Note
This fix pairs with amplifier-bundle-routing-matrix PR #30 (custom matrix loading at runtime).
Co-authored with Amplifier