Skip to content

revert: unproven default-off features per merge policy (wins only) - #30

Merged
Brian Krabach (bkrabach) merged 7 commits into
mainfrom
revert/unproven-features
Sep 3, 2026
Merged

revert: unproven default-off features per merge policy (wins only)#30
Brian Krabach (bkrabach) merged 7 commits into
mainfrom
revert/unproven-features

Conversation

@bkrabach

Copy link
Copy Markdown
Collaborator

Policy

Owner-approved merge policy: main carries wins only -- bug fixes with fail-before tests, or
features whose eval PROVED a win. Unproven default-off features live on branches/draft PRs, not
main. This PR reverts six merged features that shipped without a proven win (several explicitly
measured as not a win), while keeping the one proven fix and the one enabling infra change.

Reverted (newest to oldest; each is a standalone git revert -m 1)

Kept

Feature branches preserved for later evaluation

The reverted work is not deleted -- it remains evaluable on its original lane branches:

Test result

Full suite green on the revert branch: 87 passed (uv run pytest -q), ruff check . clean.
(Baseline before any revert on this branch: 286 passed, 1 skipped -- matches #28's own merge note.)

…was never sent (#jnt) (#28)"

This reverts commit 5cdbc62253ca80cb93f11a2fa6f7a5d3940394c78.

Not in the owner's literal revert list (#20-27), but merged AFTER #27 and
exists solely to fix a bug in the summary_call_mode="fork" code path that
#27 introduced. Once #27 (the fork feature itself) is reverted next, this
fix has no surviving target -- keeping it would leave dead code / an
orphaned test file referencing a feature no longer on main. Reverting it
first, before #27, keeps the revert of #27 itself clean.
…on call (#27)"

This reverts commit a877b36.

Merge policy: main carries wins only. summary_call_mode's fork mode was
shipped with benefit explicitly labeled unmeasured (see the original merge
note: "benefit correctly labeled unmeasured"). Unproven default-off
feature -- belongs on a branch for evaluation, not on main.
…t of compaction (#2o9) (#26)"

This reverts commit f851d12.

Merge policy: main carries wins only. clear_at_least was an unproven,
default-off predicate. Belongs on a branch for evaluation, not on main.
…ay at the tail (#4i3) (#24)"

This reverts commit 3972070.

Merge policy: main carries wins only. replay_last_user_on_compaction was
an unproven, opt-in feature. Belongs on a branch for evaluation, not on
main.
…ool) + spill-to-disk -- all defaults no-op (#21)"

This reverts commit 49e2799.

Merge policy: main carries wins only. Tool-result budget + spill-to-disk
was an unproven, all-defaults-no-op feature. Belongs on a branch for
evaluation, not on main.
… provenance (+ the never-run estimate-vs-hybrid-vs-actual measurement) (#22)"

This reverts commit f47c894.

Merge policy: main carries wins only. The hybrid token_meter mode's own
measurement was never run. Unproven, opt-in feature -- belongs on a
branch for evaluation, not on main.
…compaction (opt-in) (#20)"

This reverts commit c6dfbba.

Merge policy: main carries wins only. The summary compaction strategy's
own gate measurement showed a +83% cost regression with summarizer share
26-35%% -- falsified, not a win. Belongs on a branch for evaluation, not
on main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant