chore: add CI workflow; ship pyrightconfig.json - #79
Merged
Conversation
…fig.json This module had no CI at all. Verified clean-room: uv sync --extra dev && uv run pytest -q -> 2 failed, 1540 passed, 12 deselected. Both failures were tests/test_test_quality.py asserting pyrightconfig.json exists at repo root with "tests" and "amplifier_module_provider_github_copilot" in its "include" list -- only pyrightconfig.example.json shipped. Added the real pyrightconfig.json (derived from the example, stripped of the machine-local pythonPath). .gitignore also blanket-ignored .github/ and pyrightconfig.json under a "Local developer configuration" heading (grouped with .vscode/, .claude/, etc.) -- almost certainly an oversight, since .github/ holds CI workflows meant to be committed in virtually every GitHub repo, and pyrightconfig.json is exactly the file the repo's own test suite asserts must be committed. Removed both lines; the rest of that block (IDE/editor configs) is untouched. This repo already had addopts = "-m 'not live'" in pyproject.toml excluding 12 live-network tests by default -- CI relies on that existing behavior, no changes needed there. Note: uv sync --dev does not work here (this repo uses [project.optional-dependencies] dev, not [dependency-groups]) -- CI uses uv sync --extra dev. uv run pytest -q -> 1542 passed, 12 deselected. Generated with Amplifier (https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Contributor
Author
|
Self-authored / admin-merging at user direction as part of the family-wide CI rollout (work item 57h). CI now runs green on this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cross-repo audit of the amplifier-module-provider family found 9 of 11 repos have no CI workflow at all. This is one of the 9 (part of work item 57h).
What
Adds
.github/workflows/ci.yml: pytest on ubuntu-latest across Python 3.11 and 3.12, 10-minute timeout,uv sync --extra dev+uv run pytest -q. (This repo uses[project.optional-dependencies] dev, not[dependency-groups], so--extra devis required —--devsilently installs nothing extra.)Fixes folded in
pyrightconfig.jsonat repo root, derived from the existingpyrightconfig.example.json(stripped of the machine-localpythonPath).tests/test_test_quality.py::TestQualityGatesasserts this file exists with"tests"and"amplifier_module_provider_github_copilot"in itsincludelist — only the.example.jsonshipped, so both assertions failed..gitignorefix:.github/andpyrightconfig.jsonwere blanket-ignored under a "Local developer configuration" heading (grouped with.vscode/,.claude/, etc.) — almost certainly an oversight, since.github/holds CI workflows meant to be committed in virtually every GitHub repo, andpyrightconfig.jsonis exactly the file this repo's own test suite asserts must be committed. Removed those two lines only; the rest of that ignore block (IDE/editor configs) is untouched.This repo already excludes 12 live-network tests by default via
addopts = "-m 'not live'"inpyproject.toml— CI relies on that existing behavior unchanged.Verification
Clean-room clone:
Merge note
This PR is self-authored / admin-merged at user direction as part of the family-wide CI rollout (work item 57h). The new CI workflow will be verified running green on this PR itself before merge.