chore: add CI workflow - #40
Merged
Merged
Conversation
This module had no CI at all. Verified clean-room (VLLM_API_KEY unset -- mount() already defaults to 'EMPTY', so no dummy key is needed): uv sync --dev && uv run pytest -q -> 1 failed, 292 passed. The one failure is the inherited amplifier-core behavioral test test_list_models_returns_list, which makes a real network call to the configured endpoint. Marked @pytest.mark.live (overriding the inherited test locally to add the marker) and deselected via `-m "not live"`, mirroring the pattern used elsewhere in this rollout (provider-openai, provider-gemini). uv run pytest -q -m "not live" -> 292 passed, 1 deselected. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Collaborator
Author
|
Self-authored / admin-merging at user direction as part of the family-wide CI rollout (work item 57h). CI now runs green on this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cross-repo audit of the amplifier-module-provider family found 9 of 11 repos have no CI workflow at all. This is one of the 9 (part of work item 57h).
What
Adds
.github/workflows/ci.yml: pytest on ubuntu-latest across Python 3.11 and 3.12, 10-minute timeout,uv sync --all-extras --dev+uv run pytest -q -m "not live".Fix folded in
The inherited amplifier-core behavioral test
test_list_models_returns_listmakes a real network call to the configured vLLM/OpenAI-compatible endpoint and cannot pass in CI without a reachable server. Overrode it locally intests/test_behavioral.pyto add@pytest.mark.live, deselected via-m "not live"— the same pattern used for provider-openai/provider-gemini elsewhere in this rollout.mount()already defaultsVLLM_API_KEYto"EMPTY", so no dummy-credential workaround was needed here.Verification
Clean-room clone,
VLLM_API_KEYunset:Merge note
This PR is self-authored / admin-merged at user direction as part of the family-wide CI rollout (work item 57h). The new CI workflow will be verified running green on this PR itself before merge.