fix: coerce config bools/numerics, remove thinking_budget keys, trim wizard, add extra_request_params - #41
Merged
Brian Krabach (bkrabach) merged 1 commit intoAug 29, 2026
Conversation
…wizard, add extra_request_params - Add _coerce_bool/_coerce_int/_coerce_float helpers (warn-and-default, never crash) and apply to enable_state, raw, use_streaming, retry_jitter, max_tokens, timeout, context_window, max_output_tokens, stream_idle_timeout, priority, max_retries, min_retry_delay, max_retry_delay. - Remove thinking_budget_tokens/thinking_budget_buffer: they forced an artificial max_output_tokens floor that fought the server's own limits. extended_thinking still forces reasoning effort but no longer adjusts max_output_tokens; targeted messages point at setting max_output_tokens directly. - Add mount-time unknown-config-key sweep with difflib did-you-mean suggestions and targeted messages for ghost keys (debug, raw_debug, debug_truncate_length, thinking_budget_tokens, thinking_budget_buffer). - Remove the dead DEFAULT_DEBUG_TRUNCATE_LENGTH constant and the debug/raw_debug/debug_truncate_length README rows -- never wired. - Trim the setup wizard to base_url, api_key, context_window. stream_idle_timeout and max_output_tokens remain fully supported config keys, just settings-only now. max_tokens is NOT renamed (kept distinct from max_output_tokens; documented clearly instead). - Add extra_request_params, merged last into both the main request build and the auto-continuation build. Tests: tests/test_config_hygiene.py adds fail-before/pass-after coverage. Updated tests/test_context_limits.py and tests/test_stream_idle_timeout.py for the wizard trim (fields intentionally removed, not broken). Full suite: 318 passed, 1 pre-existing failure (test_list_models_returns_list requires network egress, fails identically on main at 37c6337). 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Collaborator
Author
|
Merging via maintainer admin override: self-authored PR (mechanical hygiene-wave fix, admin-at-user-direction), CI green, squash merge, branch retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Family hygiene wave: bool/numeric coercion (warn-and-default), removed thinking_budget_tokens/thinking_budget_buffer (artificial max_output_tokens floor), unknown-key sweep with targeted ghost-key messages (debug/raw_debug/debug_truncate_length/thinking_budget_*), removed dead DEFAULT_DEBUG_TRUNCATE_LENGTH constant, trimmed wizard to base_url/api_key/context_window (stream_idle_timeout + max_output_tokens remain settings-only), max_tokens NOT renamed, extra_request_params merged last into both the main and auto-continuation request builds. 318 passed, 1 pre-existing network-dependent failure (confirmed on main). 🤖 Generated with Amplifier