Core 10 residual: delete dead _oldest_ready_item — both conformance kits now carry zero xfail; Tier-B docstrings post-RC-2; manager records - #91
Merged
Conversation
…erred
The last deferral in either conformance kit is gone, and it is gone by
deleting the thing it named rather than by widening a check.
WHAT WAS TRUE: `webapp._oldest_ready_item` (webapp.py:902-917, 16 lines)
called `bd.list(lane=A.LANE_WORK, status="open")` with no limit at all and
had ZERO callers -- one occurrence of the name in `src/`, its own
definition. OSV1-015 read CONFORMS anyway, because Core 10 scores calls
"reached from a view" and dead code is reached by nothing; the Tier-A kit's
census is source-wide with no reachability analysis, so it went on
reporting the call and its good half was `xfail(strict=True)` naming the
row.
MEASURED, before -> after:
make test-conformance-a 41 passed / 1 xfailed -> 42 passed / 0 xfailed
0 XPASS, 0 failed
pytest ledger/checks -q 60 passed -> 60 passed
make ledger-mutate 69/69 proven -> 69/69, none unproven
ruff check / format clean -> clean (191 files)
pyright src tests 0 errors -> 0 errors
make test -- -> 1558 passed / 3 skipped
+ 127 passed, exit 0
(no documented flake hit)
WHAT MOVED WITH IT:
* the `xfail(strict=True)` marker on `test_antigoals_enforced`, and the
Tier-A module docstring's deferral table row. The docstring keeps the
mechanism and records that the kit now carries no deferral.
* `tests/unit/test_view_query_bounds.py`: `_UNREACHED_EXEMPTIONS` and
`test_the_exempted_uncapped_helpers_are_still_reached_by_nothing`, which
existed only to re-earn that one exemption. Deleted rather than left
iterating an empty set -- a guard over nothing passes forever while
proving nothing.
* `test_row_osv1_015`'s two exemption assertions, replaced by something
stronger and name-free: `all_listing_calls()`, a source-wide census of
webapp.py/webbrowse.py/webtrust.py requiring an explicit finite limit on
EVERY listing call, reached or not. Measured population, 4 of 4 explicit:
webapp.py:3848, webapp.py:4743, webbrowse.py:412, webbrowse.py:719.
The reachability audit is unchanged and still runs first.
* OSV1-006's three webapp.py register pins, -16 (1127/1823/1826 ->
1111/1807/1810). A line-number re-pin, not a re-derivation: re-measured
from the census, same eight sites, same three expressions, no growth.
Second such re-pin; the register's own comment records the first (+182).
TIER-B DOCSTRINGS, docstrings only, no assertion touched (so
`make test-conformance-b` is not required and was not run): Conformance 1
Bad, Conformance 3 Bad, and Conformance 4 Good+Bad re-quoted from the
current FROZEN contract text. All four had pre-RC-2 wording; RC-2
(2026-09-05) had reworded them onto the measured defects these very
fixtures reported -- hue outside the token set, disclosure + live-region
node identity, element-level overflow past `clientWidth`. Every refreshed
quote verified verbatim against `contracts/operator-surface.v1.md`.
LEDGER: OSV1-015 stays CONFORMS (disposition did not move and never was in
question); its "THE OTHER UNCAPPED CALL" residual paragraph is replaced by
a dated 2026-09-06 note recording the deletion, what it bought, and the
knock-on re-pin. `ledger/reconcile-report.md` gains a "## 2026-09-06 zhv"
section and one Changelog bullet.
No `contracts/` byte was touched. RESIDUAL, out of this lane's scope and
named rather than fixed: OSV1-030's notes still call Tier-A's
`test_antigoals_enforced` "the one remaining deferral in either kit" --
true when written, false as of this commit.
…er-A undeferred; Tier-B docstrings)
…didate Status -> RATIFIED; return log + plan
…dger 60, harness 69/69, pyright 0, hash match)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lane
zhv(owner's word: "yes", 2026-09-06) — contractoperator-surface.v1Core 10 (no unbounded query reached from a view). The dead_oldest_ready_item(webapp.py; one occurrence in src — its own definition; zero callers) is deleted, thexfail(strict=True)on Tier-Atest_antigoals_enforcedand its docstring row are removed, and the Tier-B kit's docstrings now quote the post-RC-2 Conformance 1/3/4 wording (assertions untouched; Tier-B not re-run — docstrings only). OSV1-015 stays CONFORMS with its residual paragraph replaced by a dated note.Manager commits (outside the lane merge): OSV1-030 prose true-up ("the one remaining deferral in either kit" is no longer true — dated paragraph, history kept); the v2 candidate's own
Status:line → RATIFIED (it was applied in #90);docs/workflow/{OWNER-RETURN-LOG,PLAN,CHECK-RECORD}.md.Manager's own re-run on the merged tree (CHECK-RECORD.md): Tier-A 42 passed / 0 xfailed (was 41/1) · ledger 60 · harness 69/69 · pyright 0 · ruff clean · contract hash == OSV1-000 pin, contract untouched. Lane's full
make test: 1558 passed, 3 skipped; no documented flake hit.Both conformance kits now carry zero deferral markers.
🤖 Generated with Amplifier