Open
Conversation
…219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15455Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15455" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Windows-only PR validation job to dogfood the Aspire CLI built in the same workflow run by creating starter templates, running aspire start, and verifying resources become ready via aspire wait.
Changes:
- Introduces
cli_starter_validation_winjob to install the PR-built Aspire CLI, trust dev certs, and smoke test starter templates on Windows. - Captures and uploads diagnostics/logs as workflow artifacts for debugging failures.
- Wires the new job into the workflow’s aggregate/required job dependencies and skip-logic for PRs.
…Copilot@users.noreply.github.com>
…19+Copilot@users.noreply.github.com>
sebastienros
requested review from
JamesNK,
davidfowl and
mitchdenny
as code owners
…6219+Copilot@users.noreply.github.com>
…6219+Copilot@users.noreply.github.com>
…3556219+Copilot@users.noreply.github.com>
sebastienros
requested review from
adamint,
danegsta and
karolz-ms
as code owners
Extract the Windows CLI starter validation harness into a reusable PowerShell script, preserve combined log formatting, and remove the flaky startup timing guard while keeping diagnostics intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sebastienros
force-pushed
the
sebros/cli-startup-check-main
branch
from
bd6f003 to
f88d0be
Compare
Make the trust-operation certificate tests explicitly use an interactive host environment so they continue validating the trust path after the Windows non-interactive CI shortcut was introduced. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 2 jobs were identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
🎬 CLI E2E Test Recordings — 49 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23505391633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new Windows PR CI validation for the Aspire CLI in
tests.ymlonmain. The workflow dogfoods the CLI built by the current PR run, creates the starter templates, runsaspire start, trusts HTTPS development certificates up front, and verifies the expected resources come up withaspire wait.Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: