Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/enumerate-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ inputs:
type: string
default: ''
description: 'Additional MSBuild arguments passed to the test matrix generation step (e.g., /p:IncludeTemplateTests=true /p:OnlyDeploymentTests=true)'
artifactSuffix:
required: false
type: string
default: ''
description: 'Suffix to append to artifact names to avoid collisions when the action is used multiple times in the same workflow run'

# Output format: JSON with structure {"include": [{...}, ...]}
# Each entry contains:
Expand Down Expand Up @@ -75,7 +80,7 @@ runs:
if: always()
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4.6.1
with:
name: logs-enumerate-tests-${{ runner.os }}
name: logs-enumerate-tests${{ inputs.artifactSuffix && format('-{0}', inputs.artifactSuffix) || '' }}-${{ runner.os }}
path: |
artifacts/log/**/*.binlog
artifacts/**/*tests-partitions.json
Expand Down
44 changes: 40 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,34 @@ jobs:
with:
versionOverrideArg: ${{ needs.prepare_for_ci.outputs.VERSION_SUFFIX_OVERRIDE }}

deployment_tests:
uses: ./.github/workflows/deployment-e2e-tests.yml
name: Deployment E2E Tests
needs: [prepare_for_ci]
permissions:
id-token: write
contents: read
secrets: inherit
# Run on non-fork PRs and push events (main/release branches), skip docs-only changes
if: >-
${{
github.repository_owner == 'microsoft' &&
needs.prepare_for_ci.outputs.skip_workflow != 'true' &&
(github.event_name == 'push' ||
github.event.pull_request.head.repo.full_name == github.repository)
}}
with:
pr_number: ${{ github.event.number && format('{0}', github.event.number) || '' }}
versionOverrideArg: ${{ needs.prepare_for_ci.outputs.VERSION_SUFFIX_OVERRIDE }}

# This job is used for branch protection. It fails if any of the dependent jobs failed
results:
if: ${{ always() && github.repository_owner == 'microsoft' }}
runs-on: ubuntu-latest
name: Final Results
needs: [prepare_for_ci, tests]
# deployment_tests is intentionally excluded: deployment failures are informational
# only (infrastructure flakiness outside the team's control should not block PRs).
needs: [prepare_for_ci, tests, deployment_tests]

steps:
- name: Fail if any of the dependent jobs failed
Expand All @@ -83,13 +105,27 @@ jobs:
# For others 'skipped' can be when a transitive dependency fails and the dependent job gets
# 'skipped'. For example, one of setup_* jobs failing and the Integration test jobs getting
# 'skipped'
#
# Note: deployment_tests is excluded from the failure check below because deployment
# failures can be caused by transient Azure infrastructure issues outside the team's
# control. Deployment results are reported in a separate informational step.
if: >-
${{ always() &&
needs.prepare_for_ci.outputs.skip_workflow != 'true' &&
needs.tests.outputs.skip_workflow != 'true' &&
(contains(needs.*.result, 'failure') ||
contains(needs.*.result, 'cancelled') ||
contains(needs.*.result, 'skipped')) }}
(needs.prepare_for_ci.result == 'failure' ||
needs.tests.result == 'failure' ||
needs.tests.result == 'cancelled' ||
needs.tests.result == 'skipped') }}
run: |
echo "One or more dependent jobs failed."
exit 1

- name: Report deployment test results
if: ${{ always() && needs.deployment_tests.result != 'skipped' }}
run: |
if [[ "${{ needs.deployment_tests.result }}" == "failure" ]]; then
echo "::warning::Deployment E2E tests failed. This is informational only and does not block the PR. Check deployment test artifacts for details."
else
echo "Deployment E2E tests passed."
fi
Loading
Loading