Log ConsoleInteractionService output to CLI log file#15521
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15521Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15521" |
Member
Author
|
Here is example CLI usage: 
Logs before: Logs after: A lot more information is available. But are there security concerns about recording output in a log file? |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds diagnostic logging for ConsoleInteractionService so interactive CLI output (prompts, status, messages, etc.) is captured in the CLI log files under ~/.aspire/logs/, using separate logger categories for stdout vs stderr.
Changes:
- Inject
ILoggerFactoryintoConsoleInteractionServiceand log key interaction events/messages. - Update CLI DI wiring in
Program.csto passILoggerFactorywhen constructing interaction services (extension + non-extension paths). - Update tests/helpers to provide a logger factory (
NullLoggerFactory.Instance) where needed.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Aspire.Cli/Interaction/ConsoleInteractionService.cs | Introduces stdout/stderr loggers and logs interaction output/events. |
| src/Aspire.Cli/Program.cs | Passes ILoggerFactory into ConsoleInteractionService from DI. |
| tests/Aspire.Cli.Tests/Utils/CliTestHelper.cs | Updates test DI factory to provide ILoggerFactory to interaction service. |
| tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs | Updates tests to construct interaction service with NullLoggerFactory.Instance. |
Member
|
I'm not too concerned about security here, its a local log file and its not like we are writing secrets or anything. The place to not log secrets is where you log the secret. |
mitchdenny
approved these changes
Mar 25, 2026
Member
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
I like the extra logging detail.
JamesNK
force-pushed
the
jamesnk/cli-interaction-logging
branch
from
5fb63be to
399d42e
Compare
adamint
approved these changes
Mar 25, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 49 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23527001476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Log ConsoleInteractionService output to the CLI log file so that console interactions (status messages, text output, prompts, selections, errors, etc.) are captured in the diagnostic log at
~/.aspire/logs/.Two ILogger categories are used to distinguish stdout vs stderr output:
Aspire.Cli.Console.Stdout- messages routed to stdoutAspire.Cli.Console.Stderr- messages routed to stderrAll messages are logged at Information level. Since the FileLoggerProvider is always active, these appear automatically in CLI log files.
Changes
ILoggerFactoryin constructor, create two loggers with stdout/stderr categories, log key interactions (status, prompts, selections, confirmations, errors, display messages, console logs, output lines)ILoggerFactoryfrom DI and pass toConsoleInteractionServicein both extension and non-extension code pathsCliTestHelper.csandConsoleInteractionServiceTests.csto passNullLoggerFactory.InstanceChecklist