Allow ACL image to be mounted as read-only.#771
Open
cwize1 wants to merge 2 commits into
Open
Conversation
The ACL image doesn't include placeholder directories for the standard linux directories (e.g. /dev) or even its own mounts (e.g. /oem). This causes problems for IC when mounting the ACL as read-only because some of the directories are missing for the mounts. To workaround this issue, an overlay is used to create the placeholder directories underneath the root partition. That way, IC has directories it can attach the mounts to. To facilitate this workaround, IC needs to know what the target distro is earlier in the process: in-between partition discovery and mounting. Also, the DistroHandler instance is now passed between more components, instead of being (re-)discovered in multiple places. Also, ensure there is a single place where all the potential `os-release` paths are listed. Also, log when a DistroHandler instance is created and which one. This could help with debugging issues relating to the picked DistroHandler implementation.
vinceaperri
reviewed
Jun 10, 2026
vinceaperri
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACL image doesn't include placeholder directories for the standard linux directories (e.g. /dev) or even its own mounts (e.g. /oem). This causes problems for IC when mounting the ACL as read-only because some of the directories are missing for the mounts.
To workaround this issue, an overlay is used to create the placeholder directories underneath the root partition. That way, IC has directories it can attach the mounts to.
To facilitate this workaround, IC needs to know what the target distro is earlier in the process: in-between partition discovery and mounting.
Also, the DistroHandler instance is now passed between more components, instead of being (re-)discovered in multiple places.
Also, ensure there is a single place where all the potential
os-releasepaths are listed.Also, log when a DistroHandler instance is created and which one. This could help with debugging issues relating to the picked DistroHandler implementation.
Checklist