Handle compressed DWARF sections in ELF binaries - #1179
Merged
Martin Kačmar (mkacmar) merged 6 commits intoSep 24, 2026
Merged
Martin Kačmar (mkacmar) merged 6 commits into
Martin Kačmar (mkacmar) merged 6 commits into
Conversation
|
Interesting that this hasn't come up before -- apparently no other toolchains produce this? or at least with flags typically used? |
Member
Author
|
Friendly ping 😸 |
Sasinkas
reviewed
May 18, 2026
Member
Author
|
Friendly ping 😸 |
Martin Kačmar (mkacmar)
requested changes
Sep 23, 2026
Martin Kačmar (mkacmar)
left a comment
Martin Kačmar (mkacmar)
left a comment
Member
There was a problem hiding this comment.
Can you add an end to end test using a real binary with compressed DWARF (there are existing tests that use checked-in ELF fixtures already)?
Member
|
Also, can you please rebase? |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
force-pushed
the
qmuntal/fix-dwarf-version-reporting
branch
from
September 23, 2026 14:29
78fc294 to
0bda534
Compare
Member
|
This looks good, can you please add some actual binaries like I mentioned in my previous comment? https://github.com/microsoft/binskim/blob/main/src/Test.UnitTests.BinaryParsers/Elf/ElfBinaryTests.cs |
Member
Author
Done! |
Martin Kačmar (mkacmar)
approved these changes
Sep 24, 2026
Martin Kačmar (mkacmar)
enabled auto-merge (squash)
September 24, 2026 12:03
Martin Kačmar (mkacmar)
disabled auto-merge
September 24, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SHF_COMPRESSEDdebug sections via raw section flagsFixes #1175