Skip to content

chore: push main.json#487

Open
Shreyas-Microsoft wants to merge 1 commit intopsl-cps-v2from
psl-vs-code-web-location
Open

chore: push main.json#487
Shreyas-Microsoft wants to merge 1 commit intopsl-cps-v2from
psl-vs-code-web-location

Conversation

@Shreyas-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request makes several updates to the infra/main.json Bicep-generated ARM template. The most significant changes include bug fixes for resource dependency ordering, improvements to parameter validation, and corrections to resource scoping for certain Azure resources. Additionally, the Bicep compiler version was downgraded, resulting in changes to template hashes throughout the file.

Resource dependency and scoping fixes:

  • Corrected the order of elements in various dependsOn arrays to ensure proper deployment sequencing for private DNS zones and related resources. This helps prevent deployment errors due to resource dependencies being out of order. [1] [2] [3]
  • Updated the scope property for Microsoft.Authorization/locks, Microsoft.Insights/diagnosticSettings, and Microsoft.Authorization/roleAssignments resources to use the correct string formatting, improving resource targeting and avoiding potential deployment issues. [1] [2] [3] [4] [5] [6]

Parameter validation improvements:

  • Added an allowedValues list to the aiServiceLocation parameter, restricting it to supported Azure regions and improving deployment reliability.

Bicep version and template hash changes:

  • Downgraded the Bicep compiler version from 0.40.2.10011 to 0.39.26.7824, resulting in updated templateHash values throughout the template. This affects metadata but not deployment logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

These changes improve the reliability and correctness of the infrastructure deployment process.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant