Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes several updates to the
infra/main.jsonBicep-generated ARM template. The most significant changes include bug fixes for resource dependency ordering, improvements to parameter validation, and corrections to resource scoping for certain Azure resources. Additionally, the Bicep compiler version was downgraded, resulting in changes to template hashes throughout the file.Resource dependency and scoping fixes:
dependsOnarrays to ensure proper deployment sequencing for private DNS zones and related resources. This helps prevent deployment errors due to resource dependencies being out of order. [1] [2] [3]scopeproperty forMicrosoft.Authorization/locks,Microsoft.Insights/diagnosticSettings, andMicrosoft.Authorization/roleAssignmentsresources to use the correct string formatting, improving resource targeting and avoiding potential deployment issues. [1] [2] [3] [4] [5] [6]Parameter validation improvements:
allowedValueslist to theaiServiceLocationparameter, restricting it to supported Azure regions and improving deployment reliability.Bicep version and template hash changes:
0.40.2.10011to0.39.26.7824, resulting in updatedtemplateHashvalues throughout the template. This affects metadata but not deployment logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]These changes improve the reliability and correctness of the infrastructure deployment process.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information