Skip to content

fix: post deployment script#500

Open
Shreyas-Microsoft wants to merge 1 commit intodevfrom
psl-fix-post-deployment-script
Open

fix: post deployment script#500
Shreyas-Microsoft wants to merge 1 commit intodevfrom
psl-fix-post-deployment-script

Conversation

@Shreyas-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request refactors how registered schema IDs and names are tracked in the infra/scripts/post_deployment.sh deployment script. The main improvement is switching from space-separated strings to Bash arrays, which makes handling and iterating over these values more robust and less error-prone.

Refactoring of schema tracking variables:

  • Changed REGISTERED_IDS and REGISTERED_NAMES from space-separated strings to Bash arrays for safer and more reliable handling.
  • Updated all assignments to REGISTERED_IDS and REGISTERED_NAMES to use array append syntax instead of string concatenation. [1] [2]
  • Refactored the loop that processes registered schemas to use array indexing, eliminating the need for manual index tracking and string manipulation.

Deployment output improvements:

  • Added a summary line at the end of the script to print the total number of schemas registered, using the array length.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Shreyas-Microsoft Shreyas-Microsoft changed the title fix post deployment script fix: post deployment script Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant