Drop unnecessary EXEC() wrapper from fabric__create_table_as#378
Open
sdebruyn wants to merge 1 commit into
Open
Drop unnecessary EXEC() wrapper from fabric__create_table_as#378sdebruyn wants to merge 1 commit into
sdebruyn wants to merge 1 commit into
Conversation
Fabric Warehouse supports CREATE TABLE AS SELECT as a first-class
statement. Wrapping it in EXEC('...') is unnecessary and forces manual
single-quote escaping of the query label via replace("'", "''"),
which is brittle. Emitting plain CTAS removes the wrapper and the
escape step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Filed as #377.
fabric__create_table_aswraps theCREATE TABLE AS SELECTinEXEC('...')and manually escapes single quotes in the query label via.replace("'", "''"). Fabric Warehouse supports CTAS as a first-class statement, so the wrapper is unnecessary, and the manual escape is fragile — it double-escapes pre-escaped apostrophes if a user-configuredquery_tagever contains''. See #377 for details.How
Drop the
EXEC()wrapper in the non-contract branch offabric__create_table_asand emit a plain CTAS. Thequery_label_optionintermediate (which only existed to call.replace("'", "''")on the label) is removed; the macro now usesquery_labeldirectly. The contract-enforced branch a few lines above already emits itsINSERT INTO ... SELECTwithout anEXEC()wrapper, so this only brings the non-contract branch into line.Test
I'm a non-Microsoft contributor and cannot run the CI against the Microsoft Fabric tenant. Happy to add a local test-run screenshot if a maintainer wants to engage with the change.
Closes #377