Surface cursor messages and statement id from get_response#390
Open
sdebruyn wants to merge 1 commit into
Open
Conversation
Replace the hardcoded 'OK' status string with the joined contents of cursor.messages, and extract the Fabric distributed statement id from the cursor output into AdapterResponse.query_id. This makes SQL warnings, PRINT output and informational notices visible during dbt runs and lets downstream tooling correlate a dbt model with its server-side query in the Fabric portal and Capacity Metrics app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389.
FabricConnectionManager.get_responsediscarded everythingcursor.messagescontained and returned a hardcoded"OK". SQL warnings,PRINToutput, deprecation notices, and the Fabric distributed statement ID never reachedAdapterResponse, so dbt users had no visibility into cursor-side diagnostics and no way to correlate a dbt model with its server-side query in the Fabric portal or Capacity Metrics app.Changes
cursor.messagesand join the message texts intoAdapterResponse._message. Falls back to"OK"only when the cursor produced no messages.Statement ID: ...incursor.messages) and pass it through asAdapterResponse.query_id.statusmessageblock is removed.Testing
Marking as draft so the maintainers can wire this through the project's test suite. Happy to extend the change with unit tests covering the message parsing and the GUID-extraction regex if that's the preferred follow-up.