Repository navigation
fix: retry experimental and MLV operations - #302
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Raki (mdrakiburrahman)
marked this pull request as ready for review
October 3, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Thank you for making change! Please fill this template for your pull request to improve quality of check-in message.
Tip
This repo uses Conventional Commit conventions - please try to rename your PR headline to match it.
Warning
Please ensure to read through this whole set of instructions, specially the
Testsection.Why this change is needed
Experimental
streaming_tableSQL bypassed the adapter connection manager and therefore ignored configured per-statement job retries. Transient failures fromCREATE STREAMING TABLEorSHOW STREAMING TABLESfailed immediately instead of honoring retry patterns and backoff.Fixes #301.
How
Routes experimental streaming SQL through
FabricSparkConnectionManager.add_query(..., auto_begin=False), preserving the owning-connection guard before consuming results. The same configured message-pattern policy now retries matching MLV on-demand refresh failures, and CI configures a narrowMLV_RUNTIME_ERRORpattern.Also bumps the adapter to 1.13.8 and adds the release changelog.
Test
Important: Non-Microsoft Employee contributors
If you are not a Microsoft employee with a
foo@microsoft.comemail, you will not be able to run CI as it runs in the@microsoft.comFabric Tenant where you do not have access.In order for your PR to be considered for review, you must attach a clear screenshot of the output of you running the following command successfully:
Targeted validation performed:
uv run pytest tests/unit/test_experimental.py::test_execute_uses_connection_manager_query_path -vv— passed (1 test).uv run pytest tests/unit/test_mlv_api.py::TestRunOnDemandRefresh::test_retries_matching_configured_failure -vv— passed (1 test).npx nx run dbt-fabricspark:publish-blob --output-style=stream— passed; built and uploadeddbt_fabricspark-1.13.8-py3-none-any.whl.Microsoft Employee contributors
Your PR will be subjected to full regression suite via GitHub Action.
It's highly recommended to run the tests locally so your contributions are promptly merged rather than failing in CI.