This repository was archived by the owner on Aug 27, 2026. It is now read-only.
Add function calls - #21
Open
Siddharth Krishna (siddharth-krishna) wants to merge 6 commits into
Open
Conversation
Siddharth Krishna (siddharth-krishna)
requested a review
from Keshav Santhanam (santhnm2)
March 15, 2021 18:36
Keshav Santhanam (santhnm2)
approved these changes
Mar 16, 2021
Keshav Santhanam (santhnm2)
left a comment
Keshav Santhanam (santhnm2)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for doing this! The only suggestion I have is to maybe add code to the prettyprinter so that we can view functions similar to the hand-written examples we've been discussing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a special "FnCall" op type to represent a function call. The subfunction of this op points to the function being called.