test: add recordings for new exists tests#154
Open
v-alexmoraru wants to merge 6 commits intomicrosoft:mainfrom
Open
test: add recordings for new exists tests#154v-alexmoraru wants to merge 6 commits intomicrosoft:mainfrom
v-alexmoraru wants to merge 6 commits intomicrosoft:mainfrom
Conversation
ayeshurun
previously approved these changes
Feb 5, 2026
ayeshurun
reviewed
Feb 5, 2026
tests/test_commands/test_exists.py
Outdated
| cli_executor.exec_command(f"exists {path}") | ||
|
|
||
| # Assert | ||
| mock_print_done.assert_called_once() | ||
| assert constant.INFO_EXISTS_FALSE in mock_print_done.call_args[0][0] | ||
|
|
||
| @pytest.mark.parametrize("item_type,folder_name", [ |
Collaborator
There was a problem hiding this comment.
can we set one list with additional property like 'should_fail' and use it in this test and the success test above? this way we are maintaing one list of items and avoiding duplications and missing anything in the future.
and depend on the property the test will skip or continue
ayeshurun
reviewed
Feb 5, 2026
tests/test_commands/test_exists.py
Outdated
| @@ -18,17 +21,18 @@ def test_exists_workspace_exists_success( | |||
| mock_print_done.assert_called_once() | |||
| assert constant.INFO_EXISTS_TRUE in mock_print_done.call_args[0][0] | |||
|
|
|||
| @custom_parametrize | |||
Collaborator
There was a problem hiding this comment.
let's find a better name like 'item_type_paramerter' so we will understand what this decorator is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.