feat(hydration): Add a hydrationStarted lifecycle callback#7269
Open
feat(hydration): Add a hydrationStarted lifecycle callback#7269
hydrationStarted lifecycle callback#7269Conversation
hydrationStarted lifecycle callback
janechu
previously approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds a
hydrationStartedlifecycle callback toHydrationControllerCallbacksand fixes the timing of hydration lifecycle events. Previously,elementWillHydratefired during the queuing/defer-hydration phase rather than at the point of actual hydration. This PR restructures the hydration pipeline so that:hydrationStartedfires once, immediately before the first element actually begins hydratingelementWillHydrateandelementDidHydratefire inline with the hydration work, not during registrationAlso expands the performance metrics test fixture and adds cross-browser Playwright tests (Chromium, Firefox, WebKit) to validate the full hydration lifecycle ordering.
👩💻 Reviewer Notes
HydratableElementControllerpreviously used privatenotifyWillHydrate,notifyDidHydrate, andnotifyHydrationCompletemethods that wrapped callbacks in try/catch. These have been inlined to reduce indirection — the try/catch blocks remain.hydrationStartedcallback uses a static boolean guard so it fires exactly once per hydration cycle, resetting whenhydrationCompleteruns.detail.sequenceon marks to verify ordering even whenperformance.now()values collide (common in WebKit due to timer coarsening).📑 Test Plan
element-register→template-update→element-define→hydration:started→ per-element hydrations →hydration:complete✅ Checklist
General
$ npm run change⏭ Next Steps