Adding strings for expand and collapsed for stackable snackbar#823
Open
pranjal-glowingstar wants to merge 5 commits intomicrosoft:masterfrom
Open
Adding strings for expand and collapsed for stackable snackbar#823pranjal-glowingstar wants to merge 5 commits intomicrosoft:masterfrom
pranjal-glowingstar wants to merge 5 commits intomicrosoft:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new accessibility announcement strings and updates StackableSnackbar behavior to announce expanded/collapsed state and manage focus when the stack expands/collapses.
Changes:
- Added
expanded_announcement/collapsed_announcementstring resources. - Announce expand/collapse via
View.announceForAccessibilitywhenstate.expandedchanges. - Introduced focus management to move focus onto a selected snackbar when expanding, and added per-item focus/semantics behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| fluentui_notification/src/main/res/values/strings.xml | Adds new string resources used for expand/collapse accessibility announcements. |
| fluentui_notification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt | Adds expand/collapse announcements, introduces focus selection/request logic, and updates semantics/focus modifiers on snackbar rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Show resolved
Hide resolved
...otification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Root cause
Fix
Validations
(how the change was tested, including both manual and automated tests)
Screenshots
Pull request checklist
This PR has considered: