Open
Conversation
Author
|
@n-gao this is a small fix needed with the latest jax |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primitive.get_bind_params(...)in the interpreterjax >= 0.9.2Root cause
For newer JAX versions, some primitives such as
integer_pow,lt, andjitreturn a plain dict fromprimitive.get_bind_params(...)instead of(subfuns, params).folxstill unpacked the result unconditionally, which caused failures likeValueError: not enough values to unpack.Validation
uv run --python 3.13 --no-dev --with pytest --with pytest-xdist --with jax==0.9.2 --with jaxlib==0.9.2 pytest test/test_interpreter.py test/test_customjvp.py test/test_operator.pyThis run passed locally on the clean upstream-only branch.