Issue400 just scalafmt formated #412
Conversation
|
Could you confirm that this was from |
|
Hi @sezruby! It's formatted with hyperspace/dev/.scalafmt.conf |
|
@dmytroDragan could you revert changes from "rearrangement"? |
There was a problem hiding this comment.
I did reviewing after 4-5 times where I did check how scalafmt reformatting is applied in my IDE and I can say that all these changes are not needed.
If we would add these changes, that it would mean that when I would apply reformatting on this file on my side, I'll be back to the original version with lots of formatting changes.
I recommend the you double check your formatting settings.
As I already posted on another of your PRs...
Here is my
scalafmtsetup in IntelliJ Idea (I have1.5.1version):
I usually do
Command+Shift+Alt+Lto reformat the file and use the following options in the dialog box:
If you use IntelliJ IDEA we can review other settings too so that you get it right. I've been through similar issues where applying formatting but after a few retries I managed to make it work and have as less possible changes into PRs due to formatting.
| name.equals(that.name) && | ||
| size.equals(that.size) && | ||
| modifiedTime.equals(that.modifiedTime) | ||
| size.equals(that.size) && |
There was a problem hiding this comment.
This is not scalafmt. I applied styling on the code and here it looks like this:
override def equals(o: Any): Boolean = o match {
case that: FileInfo =>
name.equals(that.name) &&
size.equals(that.size) &&
modifiedTime.equals(that.modifiedTime)
case _ => false
}
No extra spaces.
Please check your scalafmt.
| schemaString: String, | ||
| numBuckets: Int, | ||
| properties: Map[String, String]) | ||
| case class Properties( |
There was a problem hiding this comment.
Same here. No changes required. Here is how this part looks after I applied scalafmt reformat command:
object CoveringIndex {
case class Properties(columns: Properties.Columns,
schemaString: String,
numBuckets: Int,
properties: Map[String, String])
object Properties {
case class Columns(indexed: Seq[String], included: Seq[String])
}
}
No changes.
| case class Update( | ||
| appendedFiles: Option[Content] = None, | ||
| deletedFiles: Option[Content] = None) | ||
| case class Update(appendedFiles: Option[Content] = None, deletedFiles: Option[Content] = None) |
There was a problem hiding this comment.
Same here. I don't have any changes.
Please check you formatting settings.
| Content.fromLeafFiles(appended.map(toFileStatus), fileIdTracker), | ||
| deletedFiles = | ||
| Content.fromLeafFiles(deleted.map(toFileStatus), fileIdTracker))))))))))) | ||
| copy(source = source.copy(plan = source.plan.copy(properties = source.plan.properties.copy( |
There was a problem hiding this comment.
Neither here - I don't have any changes after applying the reformatting.
|
Th problem was with 1.5.1 vs 2.7.5 scalafmt. |
4 participants
What is the context for this pull request?
What changes were proposed in this pull request?
Files (which were changed in #402) were missing scalafmt formatting.
As result PR-402 is hard to review due to mix of issue fix and scalafmt formatting.
To resolve it, the simplest approach is to apply scalafmt formatting in first place.
After merging this PR PR-402 should be unblocked.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need