This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Deterministic index selection for filter rule with no hybrid scan #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezruby
reviewed
Apr 21, 2021
src/main/scala/com/microsoft/hyperspace/index/rankers/FilterIndexRanker.scala
Outdated
Show resolved
Hide resolved
sezruby
reviewed
Apr 21, 2021
src/main/scala/com/microsoft/hyperspace/index/rules/RuleUtils.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/rankers/FilterIndexRanker.scala
Outdated
Show resolved
Hide resolved
sezruby
reviewed
Apr 22, 2021
src/test/scala/com/microsoft/hyperspace/index/HyperspaceSuite.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/HyperspaceSuite.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/rules/HyperspaceRuleSuite.scala
Show resolved
Hide resolved
imback82
reviewed
Apr 22, 2021
src/test/scala/com/microsoft/hyperspace/index/rankers/FilterIndexRankerTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/rules/HyperspaceRuleSuite.scala
Show resolved
Hide resolved
imback82
approved these changes
Apr 22, 2021
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM (pending @sezruby's approval), thanks @apoorvedave1!
Collaborator
|
LGTM Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
Deterministic index selection for FilterIndexRule with hybrid scan disabled.
What changes were proposed in this pull request?
This PR changes the filter index rule selection from picking the
headof the eligible indexes to picking the index which hasDoes this PR introduce any user-facing change?
no
How was this patch tested?
unit tests