Implement delayed enable and disable access point#348
Merged
Conversation
lewonhee
reviewed
Oct 16, 2025
lewonhee
reviewed
Oct 16, 2025
lewonhee
requested changes
Oct 16, 2025
lewonhee
approved these changes
Oct 18, 2025
Member
Author
|
The linux build is broken because of out of diskspace that is not the issue of the code change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Implement gRPC api to enable or disable access point after specified seconds
Technical Details
WifiAccessPointTimedEnableandWifiAccessPointTimedDisableNetRemoteService::WifiAccessPointTimedEnableandNetRemoteService::WifiAccessPointTimedDisableWifiAccessPointTimedEnable APIandWifiAccessPointTimedDisable APITest Results
./netremote-test-unit "WifiAccessPointTimedDisable API"
===============================================================================
All tests passed (31 assertions in 1 test case)
===============================================================================
All tests passed (31 assertions in 1 test case)
Reviewer Focus
None
Future Work
Publish 0.5.3 release
Checklist
allcompiles cleanly.