add aitk scripts; move recipes#15
Merged
Merged
Conversation
added 20 commits
July 25, 2025 15:25
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive AITK (AI Toolkit) script framework and moves recipe configurations from a version-based structure to an AITK-based structure. The changes introduce a modular sanitization system for model configurations and standardize the organization of AI model recipes.
- Adds a complete AITK script framework with modular sanitization capabilities
- Migrates model recipes from version-based directories (e.g.,
/1/) to AITK directories (/aitk/) - Updates file paths and references across all model configurations to use the new structure
Reviewed Changes
Copilot reviewed 58 out of 74 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.aitk/scripts/sanitize/ |
New modular sanitization framework with separate modules for validation, configuration, and utilities |
| Model config files | Updated file paths from version-based to AITK-based structure in copy configurations |
info.yml files |
Added support for multiple devices and updated device configuration format |
| Requirements files | Added explanatory comments about AITK runtime requirements |
Comments suppressed due to low confidence (7)
.aitk/scripts/sanitize/utils.py:17
- The class name 'GlobalVars' violates Python naming conventions. Class names should use PascalCase, and this name should be more descriptive. Consider renaming to 'GlobalVariables' or 'SanitizeGlobals'.
class GlobalVars:
.aitk/scripts/sanitize/model_parameter.py:182
- Method name 'isEmpty' should follow Python naming conventions and be 'is_empty' (snake_case).
def isEmpty(self):
.aitk/scripts/sanitize/model_info.py:52
- Method name 'GetSortKey' should follow Python naming conventions and be 'get_sort_key' (snake_case).
def GetSortKey(self):
.aitk/scripts/sanitize/model_parameter.py:172
- Method name 'getUseX' is unclear and not descriptive. Consider renaming to 'get_active_conversion_pass' or similar to better describe what it returns.
def getUseX(self):
.aitk/scripts/sanitize/utils.py:90
- Method name 'GetRuntimeRPC' should follow Python naming conventions and be 'get_runtime_rpc' (snake_case).
def GetRuntimeRPC(cls, epName: EPNames, oliveDeviceType: OliveDeviceTypes) -> RuntimeEnum:
.aitk/scripts/sanitize/model_info.py:103
- Method name 'CheckDataset' should follow Python naming conventions and be 'check_dataset' (snake_case).
def CheckDataset(self, datasetKeys, name: str):
.aitk/scripts/sanitize/model_info.py:108
- Method name 'CheckModel' should follow Python naming conventions and be 'check_model' (snake_case).
def CheckModel(self, modelIds, name: str):
shaahji
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will setup them in github pull request later