Skip to content

add aitk scripts; move recipes#15

Merged
shaahji merged 20 commits into
mainfrom
hualxie/add_scripts
Jul 29, 2025
Merged

add aitk scripts; move recipes#15
shaahji merged 20 commits into
mainfrom
hualxie/add_scripts

Conversation

@xieofxie
Copy link
Copy Markdown
Contributor

@xieofxie xieofxie commented Jul 29, 2025

Will setup them in github pull request later

Copilot AI review requested due to automatic review settings July 29, 2025 09:18
@xieofxie xieofxie requested a review from a team as a code owner July 29, 2025 09:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive AITK (AI Toolkit) script framework and moves recipe configurations from a version-based structure to an AITK-based structure. The changes introduce a modular sanitization system for model configurations and standardize the organization of AI model recipes.

  • Adds a complete AITK script framework with modular sanitization capabilities
  • Migrates model recipes from version-based directories (e.g., /1/) to AITK directories (/aitk/)
  • Updates file paths and references across all model configurations to use the new structure

Reviewed Changes

Copilot reviewed 58 out of 74 changed files in this pull request and generated 1 comment.

File Description
.aitk/scripts/sanitize/ New modular sanitization framework with separate modules for validation, configuration, and utilities
Model config files Updated file paths from version-based to AITK-based structure in copy configurations
info.yml files Added support for multiple devices and updated device configuration format
Requirements files Added explanatory comments about AITK runtime requirements
Comments suppressed due to low confidence (7)

.aitk/scripts/sanitize/utils.py:17

  • The class name 'GlobalVars' violates Python naming conventions. Class names should use PascalCase, and this name should be more descriptive. Consider renaming to 'GlobalVariables' or 'SanitizeGlobals'.
class GlobalVars:

.aitk/scripts/sanitize/model_parameter.py:182

  • Method name 'isEmpty' should follow Python naming conventions and be 'is_empty' (snake_case).
    def isEmpty(self):

.aitk/scripts/sanitize/model_info.py:52

  • Method name 'GetSortKey' should follow Python naming conventions and be 'get_sort_key' (snake_case).
    def GetSortKey(self):

.aitk/scripts/sanitize/model_parameter.py:172

  • Method name 'getUseX' is unclear and not descriptive. Consider renaming to 'get_active_conversion_pass' or similar to better describe what it returns.
    def getUseX(self):

.aitk/scripts/sanitize/utils.py:90

  • Method name 'GetRuntimeRPC' should follow Python naming conventions and be 'get_runtime_rpc' (snake_case).
    def GetRuntimeRPC(cls, epName: EPNames, oliveDeviceType: OliveDeviceTypes) -> RuntimeEnum:

.aitk/scripts/sanitize/model_info.py:103

  • Method name 'CheckDataset' should follow Python naming conventions and be 'check_dataset' (snake_case).
    def CheckDataset(self, datasetKeys, name: str):

.aitk/scripts/sanitize/model_info.py:108

  • Method name 'CheckModel' should follow Python naming conventions and be 'check_model' (snake_case).
    def CheckModel(self, modelIds, name: str):

Comment thread openai-clip-vit-base-patch32/aitk/info.yml
@shaahji shaahji merged commit ab54065 into main Jul 29, 2025
5 checks passed
@shaahji shaahji deleted the hualxie/add_scripts branch July 29, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants