Add 28 + 35 to CMake download_retry_codes #26729
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the default in later versions of CMake, but for people in positions like me, building on older HW, depending on older dependencies, and on somewhat poor network connections, having retries as default is helpful in the build process.
This was implemented by request as per [1].
I am also building onnxruntime from source on a Jetson Orin, so I'm confined to specific CUDA/TensorRT versions as per [2], and I imagine there are others in my situation whom this would benefit!
[1] https://discourse.cmake.org/t/feature-request-more-robust-retry-policy-for-fetchcontent-externalproject-add-in-download-cmake/7560/3
[2] https://onnxruntime.ai/docs/execution-providers/TensorRT-ExecutionProvider.html#requirements
Description
Manually set
cmake_download_retriesas per latter versions ofcmakefor those compilingonnxruntimeforced to use earlier versions of cmake.Motivation and Context
I'm on a less-than-ideal internet connection, trying to build
onnxruntimefrom source on a Jetson Orin. I'm locked into older versions of CMake (understandably), andonnxruntimepulls in a bunch of dependencies. I don't want to walk away from my desk and see my build stopped 30 mins ago because downloading a zip file timed out!