Repository navigation
Copy service.name baggage onto all span attributes - #118
Merged
Merged
Conversation
Add OpenTelemetryConstants.ServiceNameKey to ActivityProcessor's AttributeKeys allow-list so that the service.name baggage value set via BaggageBuilder.OperationSource(...) is copied onto span attributes.
Nikhil Navakiran (nikhilNava)
marked this pull request as ready for review
June 9, 2026 16:57
Copilot started reviewing on behalf of
Nikhil Navakiran (nikhilNava)
June 9, 2026 16:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Agent365 tracing enrichment so that service.name set via ambient baggage (e.g., BaggageBuilder.OperationSource(...)) is actually copied onto eligible GenAI spans by ActivityProcessor, by adding OpenTelemetryConstants.ServiceNameKey to the processor’s attribute allow-list.
Changes:
- Add
OpenTelemetryConstants.ServiceNameKeytoActivityProcessor’s globalAttributeKeysallow-list so baggage propagation includesservice.name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PengF (fpfp100)
approved these changes
Jun 9, 2026
Nikhil Navakiran (nikhilNava)
approved these changes
Jun 9, 2026
Rajkumar Rangaraj (rajkumar-rangaraj)
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceNameKeywas missing fromActivityProcessor'sAttributeKeysallow-list, soBaggageBuilder.OperationSource(...)had no effect on emitted telemetry—the baggage was set but never copied to spans.OpenTelemetryConstants.ServiceNameKeyto the globalAttributeKeysarray inActivityProcessorOnStart_PropagatesServiceName_FromOperationSourceBaggageasserting thatBaggageBuilder.OperationSource(...)is correctly coalesced onto eligible GenAI spansCHANGELOG.mdwith an entry for this fixPorts the fix from microsoft/Agent365-dotnet#258.