Repository navigation
Rename Agent365 contracts package - #171
Conversation
Publish the contracts package as Microsoft.OpenTelemetry.A365.Contracts while preserving its assembly name, namespaces, and project structure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 91feee80-75d7-41e1-b724-3c3a5a932887
There was a problem hiding this comment.
🟢 Approval recommended
The rename is consistently applied while compatibility-sensitive assembly and namespace identities remain unchanged.
0 open findings
What changed in this PR
Renames the Contracts NuGet package while preserving its assembly name, namespaces, and project structure.
Changes:
- Updates the Contracts package ID and package artifact paths.
- Adjusts dependency and consumer restoration tests for distinct package and assembly names.
| File | Description |
|---|---|
PackageDependencyTests.cs |
Verifies dependencies use the new package ID. |
Microsoft.OpenTelemetry.Package.Tests.csproj |
Copies the renamed package into test feeds. |
ConsumerRestoreTests.cs |
Separates package and assembly identity assertions. |
Microsoft.Agents.A365.Observability.Contracts.csproj |
Sets the new NuGet package ID. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Harsimar Kaur (harsimar)
added
the
skip-changelog
Publish the ETW package as Microsoft.OpenTelemetry.A365.Etw while preserving its assembly name, namespaces, and project structure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 91feee80-75d7-41e1-b724-3c3a5a932887
Jianbiao Lu (alexlu4250)
left a comment
Jianbiao Lu (alexlu4250)
left a comment
There was a problem hiding this comment.
Overall looks good.
Approving with:
Non-blocking suggestion: Renaming both NuGet package IDs breaks consumers that reference the old IDs. Make the migration explicit in release notes or package documentation, including the replacement IDs: Microsoft.OpenTelemetry.A365.Contracts and Microsoft.OpenTelemetry.A365.Etw.
Publish the contracts package as Microsoft.OpenTelemetry.A365.Contracts while preserving its assembly name, namespaces, and project structure.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com