fix(a365): default InvokeAgent spans to internal - #241
Open
Nikhil Navakiran (nikhilNava) wants to merge 3 commits into
Open
Nikhil Navakiran (nikhilNava) wants to merge 3 commits into
Nikhil Navakiran (nikhilNava) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Nikhil Navakiran (nikhilNava)
marked this pull request as ready for review
September 29, 2026 18:19
Nikhil Navakiran (nikhilNava)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
ajmfehr,
Pujarini Mohapatra (biswapm),
Grant Harris (gwharris7),
Hector Hernandez (hectorhdzg),
Jeremy Voss (jeremydvoss),
Julio Carlos Menendez (juliomenendez),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
September 29, 2026 18:19
Collaborator
Author
|
Copilot resolve the merge conflicts in this pull request |
Copilot started reviewing on behalf of
Nikhil Navakiran (nikhilNava)
September 29, 2026 18:20
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the stated scope and upstream behavior with focused test coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns JavaScript InvokeAgent span behavior with the .NET implementation.
Changes:
- Defaults
InvokeAgentScopespans toSpanKind.INTERNAL. - Preserves explicit span-kind overrides.
- Updates focused tests and release notes.
| File | Description |
|---|---|
src/a365/scopes/InvokeAgentScope.ts |
Changes and documents the default span kind. |
test/internal/unit/a365/scopes.test.ts |
Verifies the new default and override behavior. |
CHANGELOG.md |
Records the behavior change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started work on behalf of
Nikhil Navakiran (nikhilNava)
September 29, 2026 18:22
View session
…-internal # Conflicts: # CHANGELOG.md Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Contributor
Resolved the merge conflict with |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Parity with the non-ETW portion of microsoft/opentelemetry-distro-dotnet#152. ETW logger changes are out of scope.