Repository navigation
test: add upstream compatibility contracts - #249
Merged
Hector Hernandez (hectorhdzg) merged 3 commits intoOct 1, 2026
Merged
Hector Hernandez (hectorhdzg) merged 3 commits into
Hector Hernandez (hectorhdzg) merged 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Hector Hernandez (hectorhdzg)
September 30, 2026 23:55
View session
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The log contract passes an incompatible wrapper to SimpleLogRecordProcessor, preventing the test from validating log export.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds compatibility tests for upstream OpenTelemetry behavior relied upon by the distro.
Changes:
- Covers Azure and core resource detectors.
- Verifies resource identity and precedence behavior.
- Tests trace, metric, log, and W3C propagation contracts.
| File | Description |
|---|---|
azureResourceDetectors.test.ts |
Tests Azure environment detection paths. |
resourceDetectors.test.ts |
Tests core resource detection and merging. |
resourceIdentityContracts.test.ts |
Tests instance identity and precedence. |
telemetrySdkContracts.test.ts |
Tests telemetry SDK and propagation behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Hector Hernandez (hectorhdzg)
September 30, 2026 23:58
View session
Preserve the upstream compatibility contract entry and current release history. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jackson Weber (JacksonWeber)
approved these changes
Oct 1, 2026
Radhika Gupta (rads-1996)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds test-only compatibility coverage for upstream OpenTelemetry behavior relied upon by the distro.
The contracts cover:
service.instance.idprecedence, opt-in behavior, stability, and worker uniquenesscloud_RoleInstance