Repository navigation
fix: remove PerRequestSpanProcessor from public API - #47
Merged
Hector Hernandez (hectorhdzg) merged 6 commits intoApr 23, 2026
Conversation
PerRequestSpanProcessor was an internal implementation detail built for a single partner and was never intended to be part of the public surface. Changes: - Delete PerRequestSpanProcessor and PerRequestSpanProcessorOptions - Remove perRequestExport option from A365Options and A365Configuration - Remove ENABLE_A365_OBSERVABILITY_PER_REQUEST_EXPORT env var support - Distro always uses BatchSpanProcessor for A365 export - Export Agent365Exporter, Agent365ExporterOptions, TokenResolver publicly so callers can build custom span processor pipelines if needed - Update MIGRATION_A365.md with a 'Custom Span Export' workaround section - Update README to remove perRequestExport docs - Update CHANGELOG
Hector Hernandez (hectorhdzg)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
April 23, 2026 21:43
Copilot started reviewing on behalf of
Hector Hernandez (hectorhdzg)
April 23, 2026 21:46
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the A365 PerRequestSpanProcessor (and related configuration) from the public surface area, standardizing A365 exporting on batch processing while making Agent365Exporter publicly available for callers who need custom span processor pipelines.
Changes:
- Deleted
PerRequestSpanProcessor+ options and removedperRequestExportfromA365Options/A365Configuration(and removed the related env var). - Updated distro initialization to always use
BatchSpanProcessorfor A365 export. - Exposed
Agent365Exporter,Agent365ExporterOptions, andTokenResolverpublicly; updated README/migration/changelog accordingly.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/internal/unit/a365/perRequestSpanProcessor.test.ts | Removed unit tests for the deleted PerRequestSpanProcessor. |
| test/internal/unit/a365/a365Configuration.test.ts | Removed assertions and cases for perRequestExport and its env var constant. |
| src/index.ts | Removed PerRequestSpanProcessor from root exports; added public exports for Agent365Exporter + types. |
| src/distro/distro.ts | Simplified A365 setup to always attach BatchSpanProcessor for A365 export. |
| src/a365/processors/index.ts | Stopped exporting PerRequestSpanProcessor and its options. |
| src/a365/processors/PerRequestSpanProcessor.ts | Deleted the per-request processor implementation. |
| src/a365/index.ts | Stopped re-exporting the per-request processor from the A365 module. |
| src/a365/configuration/A365ConfigurationOptions.ts | Removed perRequestExport from A365Options. |
| src/a365/configuration/A365Configuration.ts | Removed perRequestExport resolution and env var support. |
| README.md | Removed perRequestExport and its env var from documented A365 configuration. |
| MIGRATION_A365.md | Removed per-request export references; added “Custom Span Export” workaround guidance. |
| CHANGELOG.md | Documented breaking change removal + new public exporter exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Radhika Gupta (rads-1996)
approved these changes
Apr 23, 2026
Radhika Gupta (rads-1996)
approved these changes
Apr 23, 2026
Radhika Gupta (rads-1996)
approved these changes
Apr 23, 2026
Hector Hernandez (hectorhdzg)
merged commit Apr 23, 2026
26aed78
into
microsoft:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PerRequestSpanProcessor was an internal implementation detail built for a single partner and was never intended to be part of the public surface.
Changes:
Fixes #40