Repository navigation
Remove JSON configuration support from distro - #49
Merged
Hector Hernandez (hectorhdzg) merged 3 commits intoApr 23, 2026
Merged
Hector Hernandez (hectorhdzg) merged 3 commits into
Hector Hernandez (hectorhdzg) merged 3 commits into
Conversation
Stop reading applicationinsights.json and remove JsonConfig from shared and A365 configuration flows.\n\nUpdate tests to reflect programmatic/env-only precedence, remove obsolete JsonConfig tests/snippets, and document the breaking change in the changelog.
Hector Hernandez (hectorhdzg)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
April 23, 2026 22:39
Copilot started reviewing on behalf of
Hector Hernandez (hectorhdzg)
April 23, 2026 22:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy JSON-based configuration (applicationinsights.json and related env vars) from the distro’s configuration resolution, leaving configuration to be sourced only from programmatic options and environment variables, and updates tests/docs accordingly.
Changes:
- Removed
JsonConfigimplementation and all JSON-config merge paths from shared and A365 configuration flows. - Updated unit/snippet tests to drop JSON config scenarios and reflect programmatic/env-only precedence.
- Documented the breaking change and related startup-noise fix in the changelog.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/snippets.spec.ts | Removes README snippet test that referenced JSON config file env var. |
| test/internal/unit/shared/jsonConfig.test.ts | Deletes unit tests for JsonConfig. |
| test/internal/unit/shared/config.test.ts | Reworks config merging tests to be programmatic/env-only; adjusts option shapes to azureMonitor.*. |
| test/internal/unit/a365/a365Configuration.test.ts | Removes JSON config precedence tests for A365 configuration. |
| src/shared/jsonConfig.ts | Deletes the JSON config loader implementation. |
| src/shared/config.ts | Removes JSON config merge step; keeps env overrides as highest precedence. |
| src/a365/configuration/A365Configuration.ts | Removes JSON-config application; updates precedence docs and logic accordingly. |
| CHANGELOG.md | Notes breaking removal of JSON config support and startup-noise reduction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Radhika Gupta (rads-1996)
approved these changes
Apr 23, 2026
Hector Hernandez (hectorhdzg)
merged commit Apr 23, 2026
96f4b86
into
microsoft:main
5 checks passed
Hector Hernandez (hectorhdzg)
added a commit
that referenced
this pull request
Apr 24, 2026
…AI instrumentation interfaces and expand A365 config support (#44) * docs: expand A365 migration and configuration guidance - document console exporter enablement and behavior\n- clarify instrumentation enable/disable patterns\n- align OpenAI/LangChain instrumentation interfaces with InstrumentationConfig\n- refresh GenAI samples with explicit enabled flags * style: apply prettier formatting * feat: wire all configuration options into runtime behavior; unify GenAI instrumentation interfaces and expand A365 config support - Wire GenAI instrumentation configs (openaiAgents, langchain) into distro initialization with lifecycle cleanup - Connect A365 configuration to runtime: pass authScopes to token resolver, auto-register hosting middleware - Wire tracerName/tracerVersion into OpenAI tracer initialization - Expand A365 migration guide and README with comprehensive configuration examples - Unify GenAI instrumentation interfaces to extend InstrumentationConfig like other instrumentations - Eliminate configuration no-ops by ensuring all options drive actual runtime behavior Closes: #44 * fix: import OpenAIAgentsInstrumentationConfig from types to include tracerName/tracerVersion The local interface definition in openAIAgentsTraceInstrumentor.ts was shadowing the actual type from src/types.ts which includes tracerName and tracerVersion properties. This caused TypeScript compilation errors. Import the type from src/types.ts and remove the incomplete local definition. * fix: remove unused InstrumentationConfig import The import was leftover from removing the local interface definition. OpenAIAgentsInstrumentationConfig is imported from src/types.js which already extends InstrumentationConfig, so this import is unnecessary. * Update * Remove JSON configuration support from distro (#49) * Remove JSON configuration support from distro Stop reading applicationinsights.json and remove JsonConfig from shared and A365 configuration flows.\n\nUpdate tests to reflect programmatic/env-only precedence, remove obsolete JsonConfig tests/snippets, and document the breaking change in the changelog. * Fix misleading config validation test assertion * fix: resolve build errors, formatting issues for CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop reading applicationinsights.json and remove JsonConfig from shared and A365 configuration flows.\n\nUpdate tests to reflect programmatic/env-only precedence, remove obsolete JsonConfig tests/snippets, and document the breaking change in the changelog.
Fixes #46