Skip to content

Add support for local mypy, pylint, black checks - #14

Merged
Radhika Gupta (rads-1996) merged 7 commits into
microsoft:mainfrom
rads-1996:add-tox-checks
Apr 6, 2026
Merged

Radhika Gupta (rads-1996) merged 7 commits into
microsoft:mainfrom
rads-1996:add-tox-checks

Conversation

@rads-1996

Copy link
Copy Markdown
Member

Use the following commands to run these checks locally -

python -m tox run -e pylint -c <pathto/eng/tox/tox.ini> --root .
python -m tox run -e mypy -c <pathto/eng/tox/tox.ini> --root .
python -m tox run -e black -c <pathto/eng/tox/tox.ini> --root .

@rads-1996
Radhika Gupta (rads-1996) marked this pull request as ready for review April 3, 2026 19:56
Copilot AI review requested due to automatic review settings April 3, 2026 19:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a self-contained eng/tox configuration to enable running local static checks (mypy, pylint, black) via tox from the repo root.

Changes:

  • Introduces eng/tox/tox.ini with environments for mypy, pylint, black, and pytest.
  • Adds helper runner scripts for mypy/pylint and a tox python hook to provide a {repository_root} constant.
  • Adds dev_requirements.txt used by tox env dependency installation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
eng/tox/toxfile.py Adds a tox hook that derives and exposes {repository_root}.
eng/tox/tox.ini Defines tox envs/commands for mypy, pylint, black, pytest.
eng/tox/run_pylint.py Script wrapper to run pylint on src/ and optionally tests/.
eng/tox/run_mypy.py Script wrapper to run mypy on src/ and optionally tests/ (samples currently disabled).
dev_requirements.txt Shared dependency list referenced by tox envs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eng/tox/run_mypy.py Outdated
Comment thread eng/tox/run_pylint.py Outdated
Comment thread eng/tox/toxfile.py
Comment thread eng/tox/tox.ini Outdated
Comment thread eng/tox/tox.ini Outdated
Comment thread eng/tox/tox.ini
Comment thread eng/tox/tox.ini Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eng/tox/toxfile.py
Comment thread eng/tox/toxfile.py
Comment thread eng/tox/tox.ini
Comment thread eng/tox/run_pylint.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rads-1996
Radhika Gupta (rads-1996) merged commit 81625be into microsoft:main Apr 6, 2026
6 checks passed
@rads-1996
Radhika Gupta (rads-1996) deleted the add-tox-checks branch April 6, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants