Skip to content

Fix editable version import style - #261

Merged
Radhika Gupta (rads-1996) merged 3 commits into
microsoft:mainfrom
rads-1996:fix-sample
Sep 10, 2026
Merged

Radhika Gupta (rads-1996) merged 3 commits into
microsoft:mainfrom
rads-1996:fix-sample

Conversation

@rads-1996

@rads-1996 Radhika Gupta (rads-1996) commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

Fix the import style in the sample
Remove release.yaml, it requires us to give github actions control to create/approve PRs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, low-risk sample-only import update that aligns with the package’s documented public entry point.

Pull request overview

This PR updates a LangChain sample to import use_microsoft_opentelemetry from the public package entry point (microsoft.opentelemetry) rather than the internal module (microsoft.opentelemetry._distro), aligning the sample with the library’s intended API surface.

Changes:

  • Switch sample import from microsoft.opentelemetry._distro to microsoft.opentelemetry.
File summaries
File Description
samples/langchain/sample_langchain_instrumentation.py Uses the public microsoft.opentelemetry import path for use_microsoft_opentelemetry.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Performance comparison

Threshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.

Scenario Gating Baseline (ops/s) Candidate (ops/s) Δ % Status
azure_monitor_log yes 24,377.8 24,691.4 -1.27% ✅
azure_monitor_span yes 160,025.6 159,769.9 +0.16% ✅
otel_log no 28,063.9 28,294.9 -0.82% ✅
otel_span no 48,236.9 48,730.6 -1.01% ✅

@rads-1996 Radhika Gupta (rads-1996) added the skip-changelog Not required for changes to test files, github actions, etc. label Sep 10, 2026
@rads-1996
Radhika Gupta (rads-1996) merged commit fe80d3a into microsoft:main Sep 10, 2026
12 checks passed
@rads-1996
Radhika Gupta (rads-1996) deleted the fix-sample branch September 10, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Not required for changes to test files, github actions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants