Repository navigation
Add InvokeAgent GenAI semantic parameters - #263
Merged
Hector Hernandez (hectorhdzg) merged 15 commits intoSep 16, 2026
Merged
Hector Hernandez (hectorhdzg) merged 15 commits into
Hector Hernandez (hectorhdzg) merged 15 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Nikhil Navakiran (nikhilNava)
marked this pull request as ready for review
September 15, 2026 18:04
Copilot started reviewing on behalf of
Nikhil Navakiran (nikhilNava)
September 15, 2026 18:05
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Documentation examples and model descriptions need correction before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Python-native GenAI request/response parameter models for InvokeAgent spans and emits related semantic-convention attributes.
Changes:
- Added request/response parameter models and public exports.
- Recorded request, response, usage, and cache-token attributes.
- Added tests, documentation, and changelog updates.
File summaries
| File | Summary | Findings |
|---|---|---|
tests/a365/test_invoke_agent_scope.py |
Tests parameter recording behavior. | — |
src/microsoft/opentelemetry/a365/README.md |
Documents core modules and models. | Nit (3 votes): describe the models as GenAI parameter models rather than message payload models. |
src/microsoft/opentelemetry/a365/core/invoke_agent_scope.py |
Emits GenAI semantic attributes. | — |
src/microsoft/opentelemetry/a365/core/invoke_agent_details.py |
Adds request/response parameter fields. | — |
src/microsoft/opentelemetry/a365/core/gen_ai_response_parameters.py |
Defines response parameters. | — |
src/microsoft/opentelemetry/a365/core/gen_ai_request_parameters.py |
Defines request parameters. | — |
src/microsoft/opentelemetry/a365/core/constants.py |
Adds semantic-convention keys. | — |
src/microsoft/opentelemetry/a365/core/__init__.py |
Exports the new models. | — |
src/microsoft/opentelemetry/a365/constants.py |
Mirrors semantic-convention keys. | — |
README.md |
Documents the new API. | Nit (1 vote): the example omits imports or definitions for InvokeAgentScope, request, and agent_details. Nit (2 votes): the example omits the InvokeAgentScope import. |
CHANGELOG.md |
Records the new feature. | — |
A365_DOCUMENTATION.md |
Expands InvokeAgent documentation. | — |
Review details
Suppressed comments (1)
README.md:130
- This example cannot be copied as shown: it uses
InvokeAgentScope,request, andagent_detailswithout importing or defining them, so it raisesNameErrorbefore demonstrating the new API. Include those imports and initialize the request and agent objects as in the full guide.
from microsoft.opentelemetry.a365.core import GenAiRequestParameters, GenAiResponseParameters, InvokeAgentScopeDetails
- Files reviewed: 12/12 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jackson Weber (JacksonWeber)
approved these changes
Sep 16, 2026
Hector Hernandez (hectorhdzg)
approved these changes
Sep 16, 2026
Hector Hernandez (hectorhdzg)
merged commit Sep 16, 2026
8c1178e
into
microsoft:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python parity for microsoft/opentelemetry-distro-dotnet#120.
Validation
Full mypy still reports the existing missing stubs for msal in an untouched module.