Enable Agent Framework GenAI message events - #270
Merged
Hector Hernandez (hectorhdzg) merged 11 commits intoSep 29, 2026
Merged
Hector Hernandez (hectorhdzg) merged 11 commits into
Hector Hernandez (hectorhdzg) merged 11 commits into
Conversation
Copilot started reviewing on behalf of
Hector Hernandez (hectorhdzg)
September 18, 2026 20:04
View session
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
force=True is not forwarded, and its configuration is not documented.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enables Agent Framework GenAI message events by default with legacy API compatibility and configurable instrumentation options.
Changes:
- Adds message-event defaults, overrides, and compatibility handling.
- Expands tests for configuration and legacy signatures.
- Documents the feature and records it in the changelog.
File summaries
| File | Summary |
|---|---|
tests/test_agent_framework_integration.py |
Updates integration expectations. |
tests/agent_framework/test_trace_instrumentor.py |
Tests defaults, overrides, forced behavior, and legacy compatibility. |
src/microsoft/opentelemetry/_agent_framework/_trace_instrumentor.py |
Forwards Agent Framework instrumentation settings; force is not currently forwarded. |
README.md |
Documents Agent Framework options; force documentation is missing. |
CHANGELOG.md |
Records the new feature. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Radhika Gupta (rads-1996)
left a comment
Radhika Gupta (rads-1996)
left a comment
Member
There was a problem hiding this comment.
Two things here -
We should probably the bump the minimum version or atleast recommend the version of agent-framework in which this feature is available and we could also add a sample app.
Radhika Gupta (rads-1996)
left a comment
Radhika Gupta (rads-1996)
left a comment
Member
There was a problem hiding this comment.
Should we also update the min version for agent-framework in pyproject.toml?
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Forward and document the force option, cover forced re-enablement, and move the optional dependency API contract into the integration suite that installs Agent Framework. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Hector Hernandez (hectorhdzg)
force-pushed
the
hectorhdzg-support-message-events
branch
from
September 29, 2026 00:23
35874ea to
b0ed798
Compare
Keep the API contract in the integration suite while allowing the base pytest environments to collect tests without the optional Agent Framework dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Avoid conditional loading of the optional Agent Framework dependency; the minimum version and instrumentor behavior remain covered by package metadata and unit tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
| ) | ||
| ``` | ||
|
|
||
| For Agent Framework, `enable_sensitive_data` controls prompt, completion, |
Member
Author
There was a problem hiding this comment.
They’re separate settings, but message events are only emitted when sensitive-data capture is also enabled. So setting enable_message_events=True by itself won’t emit message content if enable_sensitive_data=False
Jackson Weber (JacksonWeber)
approved these changes
Sep 29, 2026
Hector Hernandez (hectorhdzg)
merged commit Sep 29, 2026
f4abb9e
into
microsoft:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_message_eventsandforcethroughinstrumentation_options["agent_framework"]enable_message_eventsThis consumes the Agent Framework API added for microsoft/agent-framework#8412.