Skip to content

Restore MOT version propagation after OneSettings initialization order caused the exporter version to take precedence over the Microsoft OpenTelemetry distro version - #275

Merged
Radhika Gupta (rads-1996) merged 4 commits into
microsoft:mainfrom
rads-1996:add-back-mot-visibility
Sep 25, 2026
Merged

Radhika Gupta (rads-1996) merged 4 commits into
microsoft:mainfrom
rads-1996:add-back-mot-visibility

Conversation

@rads-1996

Copy link
Copy Markdown
Member

…

…r caused the exporter version to take precedence over the Microsoft OpenTelemetry distro version
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Performance comparison

Threshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.

Scenario Gating Baseline (ops/s) Candidate (ops/s) Δ % Status
azure_monitor_log yes 40,099.4 39,402.7 +1.77% ✅
azure_monitor_span yes 288,142.9 289,855.1 -0.59% ✅
otel_log no 47,682.6 47,276.9 +0.86% ✅
otel_span no 88,912.6 85,631.1 +3.83% ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Add regression coverage verifying the configuration manager receives the distro version.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Restores Microsoft OpenTelemetry distro version precedence during OneSettings initialization.

Changes:

  • Reorders initialization so the distro version is set before configuration loading.
  • Adds an unreleased changelog entry.
File Summary
src/​microsoft/​opentelemetry/​_distro.py Ensures version propagation precedes OneSettings initialization.
CHANGELOG.md Documents the version propagation fix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/microsoft/opentelemetry/_distro.py
@rads-1996
Radhika Gupta (rads-1996) merged commit 2759828 into microsoft:main Sep 25, 2026
12 checks passed
@rads-1996
Radhika Gupta (rads-1996) deleted the add-back-mot-visibility branch September 25, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants