Skip to content

Add upstream dependency compatibility regression tests - #279

Merged
Radhika Gupta (rads-1996) merged 4 commits into
microsoft:mainfrom
hectorhdzg:hectorhdzg-upstream-compatibility-tests
Oct 1, 2026
Merged

Radhika Gupta (rads-1996) merged 4 commits into
microsoft:mainfrom
hectorhdzg:hectorhdzg-upstream-compatibility-tests

Conversation

@hectorhdzg

Copy link
Copy Markdown
Member

Summary

  • add network-isolated contract tests for Azure resource detectors and core OpenTelemetry SDK behavior
  • validate dependency imports, plugin registration, and Azure Monitor/OTLP exporter construction
  • add service.instance.id regression coverage for worker uniqueness, fork refresh, AKS/VM precedence, and bounded cardinality
  • document known OpenTelemetry SDK 1.44 precedence defects as strict expected failures

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Performance comparison

Threshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.

Scenario Gating Baseline (ops/s) Candidate (ops/s) Δ % Status
azure_monitor_log yes 16,530.6 16,690.9 -0.96% ✅
azure_monitor_span yes 149,209.2 156,445.6 -4.63% ✅
otel_log no 18,968.5 19,157.8 -0.99% ✅
otel_span no 40,638.8 41,640.6 -2.41% ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Known defects are not collected as strict expected failures, and some compatibility assertions do not validate their intended contracts.

Review effort: Balanced
Findings: 3 Medium severity

Open (3)
What changed in this PR

Adds isolated compatibility tests covering upstream OpenTelemetry and Azure dependencies.

Changes:

  • Tests SDK telemetry contracts and plugin/exporter compatibility.
  • Covers Azure resource detection and service.instance.id behavior.
  • Blocks external network access during upstream tests.
File Description
tests/​upstream/​__init__.py Defines the upstream test package.
tests/​upstream/​conftest.py Adds network-isolation fixtures.
tests/​upstream/​test_azure_resource_detectors.py Tests Azure detector contracts.
tests/​upstream/​test_dependency_plugins.py Checks dependencies, plugins, and exporters.
tests/​upstream/​test_opentelemetry_sdk_contracts.py Exercises core SDK behavior.
tests/​upstream/​test_service_instance_id_regressions.py Covers instance-ID precedence and fork behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/upstream/test_azure_resource_detectors.py Outdated
Comment thread tests/upstream/test_opentelemetry_sdk_contracts.py
Comment thread tests/upstream/test_service_instance_id_regressions.py Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 00:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes are comprehensive, isolated tests with intentional strict coverage for known upstream defects.

Review effort: Balanced
Findings: None

Resolved since last review (3)

Comment thread tests/upstream/test_dependency_plugins.py
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The regression tests are comprehensive, isolated, and pass across the supported Python versions.

Review effort: Balanced
Findings: None

@rads-1996
Radhika Gupta (rads-1996) merged commit 5514a7f into microsoft:main Oct 1, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants