Repository navigation
Refactor + update PLANNING - #34
Merged
Merged
Conversation
Leighton Chen (lzchen)
requested a review
from Hector Hernandez (hectorhdzg)
as a code owner
April 16, 2026 03:43
Leighton Chen (lzchen)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
Jeremy Voss (jeremydvoss) and
Radhika Gupta (rads-1996)
as code owners
April 16, 2026 03:43
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the distro setup to better compose OTLP + Azure Monitor pipelines, updates configuration constants, and adds runnable OTLP samples/documentation alongside PLANNING.md status updates.
Changes:
- Refactors OTLP component creation to be per-signal (
enable_traces/metrics/logs) and wires it through_append_otlp_components. - Refactors kwargs splitting for Azure Monitor vs general OTel args and standardizes the live-metrics key via a constant.
- Adds OTLP collector/sample app docs and updates existing samples/PLANNING notes.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/microsoft/opentelemetry/_utils.py | Updates OTLP wiring and Azure Monitor configuration handling/constants. |
| src/microsoft/opentelemetry/_otlp/handler.py | Adds per-signal OTLP component creation and moves OTLP imports. |
| src/microsoft/opentelemetry/_distro.py | Refactors kwarg splitting / provider setup flow and logging handler import. |
| src/microsoft/opentelemetry/_constants.py | Adds ENABLE_LIVE_METRICS_ARG. |
| src/microsoft/genai/_langchain/init.py | Adds clarifying comment about temporary internal instrumentation. |
| samples/otlp/tracing.py | New OTLP trace sample. |
| samples/otlp/collector-config.yaml | New local collector config for OTLP sample. |
| samples/otlp/README.md | New instructions for running OTLP sample + collector. |
| samples/langchain/requirements.txt | Adds sample requirements for LangChain scenario. |
| samples/distro/tracing.py | Sample now reads connection string from env. |
| samples/distro/metrics.py | Sample now reads connection string from env. |
| samples/distro/logging_sample.py | Sample now reads connection string from env. |
| samples/distro/fastapi_app.py | Sample updates endpoints/host binding and reads connection string from env. |
| samples/distro/custom_events.py | Sample now reads connection string from env. |
| PLANNING.md | Marks completed phases and updates instrumentation references/names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.