flowey: fix more issues with running vmm-tests under wsl#2653
Open
chris-oo wants to merge 3 commits intomicrosoft:mainfrom
Open
flowey: fix more issues with running vmm-tests under wsl#2653chris-oo wants to merge 3 commits intomicrosoft:mainfrom
chris-oo wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issues with running cross-compiled Windows VMM tests under WSL. It enables end-to-end execution of cargo xflowey vmm-tests --target windows-x64 --dir /mnt/q/vmm_tests_out within WSL by ensuring proper environment variable propagation and path validation.
Changes:
- Added WSLENV configuration to propagate environment variables when running Windows executables from WSL
- Added validation to ensure Windows-accessible paths are used when targeting Windows from WSL
- Made
running_in_wsl()function public in flowey_cli for reuse across crates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
flowey/flowey_lib_hvlite/src/run_prep_steps.rs |
Adds WSLENV handling to propagate environment variables when running Windows prep_steps executable from WSL |
flowey/flowey_hvlite/src/pipelines/vmm_tests.rs |
Validates output directory is Windows-accessible when targeting Windows from WSL |
flowey/flowey_cli/src/lib.rs |
Makes running_in_wsl() function public and adds documentation |
benhillis
reviewed
Jan 15, 2026
6ff355d to
c5039bd
Compare
c5039bd to
7dcead5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two additional fixes for running cross compiled windows under WSL for vmm-tests. This now allows running something like
cargo xflowey vmm-tests --target windows-x64 --dir /mnt/q/vmm_tests_outend to end, and having it build and execute all tests within WSL.