feat(bytesbuf): improve ergonomics of BytesView::as_read()#272
Merged
sandersaares merged 7 commits intomainfrom Feb 20, 2026
Merged
feat(bytesbuf): improve ergonomics of BytesView::as_read()#272sandersaares merged 7 commits intomainfrom
sandersaares merged 7 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 141 141
Lines 8626 8626
=======================================
Hits 8626 8626 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
55449e8 to
41ddeb0
Compare
|
- Make BytesViewReader a public named type (was pub(crate)) - Rename as_read() to reader() and return BytesViewReader<'_> - Implement std::io::BufRead using first_slice()/advance() - Update documentation to reflect BufRead support - Add tests for BufRead (fill_buf, consume, read_line, empty view) Closes #268 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
41ddeb0 to
74be3f6
Compare
martintmk
reviewed
Feb 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
martintmk
approved these changes
Feb 19, 2026
geeknoid
approved these changes
Feb 19, 2026
martintmk
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR now simplifies the
bytesbufread path by removing theBytesViewReaderwrapper and implementingstd::io::Readandstd::io::BufReaddirectly onBytesView.What changed
bytesbuffunctional changesBytesViewReaderwas removed.ReadandBufReadare implemented directly forBytesView.BytesView::reader()was removed.read_adapter.rsmodule was renamed toview_read.rsto match its contents.bytesbufdocs were updated to describe directRead/BufReadsupport onBytesView.Repository maintenance changes included in this branch
just format(format-only updates across the repository).just readmeand committed generated README updates.AGENTS.mdwith README/format guidance and a pre-commit checklist.Validation
cargo clippy -p bytesbuf --all-features -- -D warningscargo test -p bytesbuf --all-features