Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 140 140
Lines 8620 8636 +16
=======================================
+ Hits 8620 8636 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandersaares
approved these changes
Feb 19, 2026
|
|
||
| impl std::fmt::Debug for ClockControl { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| let state = self.state.lock().expect("acquiring lock must always succeed"); |
Member
There was a problem hiding this comment.
This is just unwrap() in more verbose form. Is there a reason we expect acquiring the lock to always succeed? If so, we should document that reason in the expect-message (i.e. what makes it impossible for this lock to get poisoned).
geeknoid
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the default debug implementation was too noisy